Closed Bug 1943008 Opened 7 months ago Closed 6 months ago

The selected tab is not always overlapping the first or last tab while manually reordering tabs in tabs tray

Categories

(Firefox for Android :: Tabs, defect)

Firefox 136
All
Android
defect

Tracking

()

VERIFIED FIXED
136 Branch
Tracking Status
firefox134 --- unaffected
firefox135 --- unaffected
firefox136 --- verified

People

(Reporter: dpop, Unassigned)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [fxdroid][group4])

Attachments

(3 files)

Attached video first tab.mp4

Steps to reproduce

  1. Go to Tab settings and make sure the Tab view is on "Grid".
  2. Open a few tabs and then open the tabs tray.
  3. Long tap on any tab and drag it to the first or last position to reorder the two tabs.
  4. Observe.

Expected behavior

The moved tab is always displayed above the other tabs (overlapped).

Actual behavior

Sometimes, the moved tab would be displayed under the first or the last tab from tabs tray, while correctly overlapping the other tabs.

Device information

  • Firefox version: Reproduced with all latest releases: Nightly 136.0a1 from 01/22, could not be reproduced in Beta or Release
  • Android device model / Android OS version: Samsung GalaxyZ Fold 4 (Android 14), Samsung Galaxy A53 5G (Android 14) Google Pixel 8 Pro (Android 14)

Additional information

This issue appears to be random, and has a low repro rate.
I could not reproduce it yet with Tab view set to "List".
Might be a regression from 1904906

Attached video last tab.mp4
No longer regressed by: 1904906

I do think this is regressed from Bug 1904906. FWIW, this behaviour is also seen in the video that I posted on Bug 1942855 and in that case I'm simply swiping to close a tab and not reordering the tabs.

Regressed by: 1904906

:007, since you are the author of the regressor, bug 1904906, could you take a look?

For more information, please visit BugBot documentation.

Flags: needinfo?(nbond)

After Bug 1942735 lands, can QA please verify if the issue is still reproducible?

Flags: needinfo?(nbond) → qe-verify+

:007 should this be resolved as a duplicate of Bug 1942735?
:Nick, aiui qe-verify+ is only picked up by QA on resolved bugs

Flags: needinfo?(nbond)

should this be resolved as a duplicate of Bug 1942735?

Right now, we think the underlying cause of all these Tabs Tray issues are coming from the rewrite that happened in Bug 1904906. There was a fix that happened in Bug 1942735 to fix the underlying swipe to close behaviour but we should keep this open in case this issue still persists, even though other related issues were fixed. When testing locally, I couldn't reproduce this issue but just to be sure, we should wait for QA or :dpop to confirm

aiui qe-verify+ is only picked up by QA on resolved bugs

I use this too when I'm unable to reproduce a bug and ask QA to try to reproduce it so I think it should be fine - thanks for calling this out though :)

Flags: needinfo?(nbond)

I use this too when I'm unable to reproduce a bug and ask QA to try to reproduce it so I think it should be fine - thanks for calling this out though :)

Sorry if I wasn't clear, but this bug will not appear in the QA's qe-verify+ list since it's in an open state. The keyword won't action anything.

:dpop would you mind looking at this bug when you have a moment? See if it still reproduced for you?

Flags: needinfo?(dpop)

I can no longer reproduce this issue in the latest Nightly 136.0a1 from 01/27.
Tested with the same devices the issue was reproducible on, and as well as different ones: Samsung Galaxy A53 5G (Android 14), Google Pixel 8 Pro (Android 14), Samsung GalaxyZ Fold 4 (Android 14), Nothing Phone (2a) 5G (Android 14) and Lenovo Yoga Tab 11 (Android 12).
I'll close this ticket as fixed.

Status: NEW → RESOLVED
Closed: 6 months ago
Flags: qe-verify+
Flags: needinfo?(dpop)
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Target Milestone: --- → 136 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: