1943094 - PDF rendering should be aware of the max canvas dimensions

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, enhancement)

Description

[Nicolò Ribaudo]

Attach (recommended) or Link to PDF file here: https://github.com/mozilla/pdf.js/issues/12957

Steps to reproduce the problem:

1. Zoom that PDF

What is the expected behavior? (add screenshot)

To avoid drawing canvases that are too big, pdf.js already limits their area to a maximum number and uses CSS zoom rather than a larger canvas. However, just checking the area is not enough for very narrow and very tall documents: pdf.js should also limit the width/height of canvases (defined as https://searchfox.org/mozilla-central/source/modules/libpref/init/StaticPrefList.yaml#6208), and trigger the CSS zoom mode once it reaches Firefox's limit.

What went wrong? (add screenshot)

That PDF cannot be rendered above certain zoom levels.

Comment 1

[BMO Github Automation]

Attachment: [mozilla/pdf.js] [api-minor] Limit the maximum canvas width/height, in addition to its total area (bug 1943094) (#19604)

Comment 2

[Jonas Jenwald [:Snuffleupagus]]

Attachment: Bug 1943094 - Expose the maximum canvas dimension to the PDF Viewer. r=#pdfjs-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c25cb31d4377
Expose the maximum canvas dimension to the PDF Viewer. r=pdfjs-reviewers,calixte

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/c25cb31d4377