1943359 - Clean up subscriptions from session subscription map when a context is destroyed

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P3)

Description

[Alexandra Borovova [:Sasha]]

During the implementation of subscription IDs for session.subscribe and unsubscribe (see bug 1938576) we didn't implement the cleanup of subscriptions from session subscription map as the spec requires (see https://w3c.github.io/webdriver-bidi/#event-browsingContext-contextDestroyed). This probably shouldn't cause any real issue. But it could be nice to implement to free up some memory.

Comment 1

[Sameem [:sameembaba]]

Attachment: Bug 1943359 - Clean up subscriptions from session subscription map when a context is destroyed. r=Sasha

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/aa9d7a5bc2ac
https://hg.mozilla.org/integration/autoland/rev/429f3556d399
Clean up subscriptions from session subscription map when a context is destroyed. r=Sasha

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/429f3556d399

Comment 4

[Sameem [:sameembaba]]

Hi Sasha! Thanks again for assigning me this.I really enjoyed working on it. I'm looking to continue contributing to WebDriver BiDi. If you know of any bugs that would benefit from attention, especially higher-priority ones or ones that would be good next issues to work on, I'd really appreciate your recommendations.

Comment 5

[Alexandra Borovova [:Sasha]]

Hi! It's great to hear :)
We have, for example, this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1969880. Does it look like something you would like to work on?

Comment 6

[Sameem [:sameembaba]]

Yeah! I can give it a try.

Comment 7

[Alexandra Borovova [:Sasha]]

Great! I've assigned it to you. As usual, let me know if something is unclear.