1943361 - Requesting GitHub membership to the ads related orgs for [e-mail]

Status: RESOLVED FIXED

(mozilla.org :: Github: Administration, task)

Description

[Justin D'Arcangelo [:justindarc]]

Hello colleagues,

I've read https://wiki.mozilla.org/GitHub#Team_Maintainers_.26_Project_Leads, and need help adding a contributor to the org:

Name: Justin D'Arcangelo
Mozilla Email: [e-mail]
Github Profile link: https://github.com/justindarc
Github Team(s) REQUIRED:
https://github.com/orgs/mozilla-services/teams/ads-engineering
https://github.com/orgs/mozilla/teams/ads-engineering
https://github.com/orgs/mozilla-sre-deploy/teams/ads-engineering
https://github.com/orgs/mozilla-it/teams/ads-engineering
https://github.com/orgs/Pocket/teams/ads

If this is not being requested by a team maintainer, please request their approval via need-info.

I am a maintainer on all these orgs except Pocket/team/ads, so I will request Daniel Mueller's approval for that one.

Comment 1

[Chris Knowles [:cknowles]]

Alright, I see that your GitHub ID is linked to your people.m.o profile. And that you've NI'd :dmueller who is one of the maintainers for all requested teams.

Pulling the NI for :cburgess - they're not a maintainer of the teams involved. (though any existing maintainer can modify the team maintainers.)

Let me know if you have any questions

Comment 2

[cgramberg]

I can confirm that Justin has joined our team (I think I should be a maintainer in all of these groups).

Comment 3

[Chris Knowles [:cknowles]]

Unfortunately, you're not currently maintainer on any of the requested teams. Certainly any maintainer can make you one, OR GHE folk can do it with teh approval of an existing maintainer.

Comment 4

[Catherine Burgess]

Well this continues to be a hilarious day for our team in finding out the things I and others are not in lol

I've asked Masha to add Chris as a maintainer and will add her on this ticket.

Can we add this repo to Justin's request as well? https://github.com/mozilla-services/ads-sdk

Comment 5

[Chris Knowles [:cknowles]]

You're in the team(s) (except perhaps in pocket) - you're just not maintainers of it. Masha - you can either give me a thumbs up and I can modify whoever you designate as maintainers, or you're welcome to do it yourself.

And the mozilla-services/ads-sdk repo is covered by the request to add them to the ads-engineering team in mozilla-services.

So you have the data all in one place, here's the membership of the teams - users with "*" are maintainers. Note that the membership and role is the same in all the Enterprise orgs.
*cbguder
*efixler
*mashalifshin
*dmueller
*cyptm
*bbirdsong2
*daliaSaid
*tanfarming
*kauana
*gleonard-m
*nanagb
*akhan-mozilla
railor33
luc-lisi
shogan-mozilla
cburgessmozilla
chrisgramberg

And here's the setup in pocket:
*cbguder
*efixler
*mashalifshin
*dmueller
*izo3
*cyptm
*bbirdsong2
*daliaSaid
*kauana
*gleonard-m
*nanagb
*akhan-mozilla
railor33
luc-lisi
chrisgramberg

Comment 6

[mlifshin]

Hi Chris,

I can give the thumbs up for Justin as he is our new team member.

I also went ahead and updated the Ads Engineering teams across the orgs to have Luc Lisi and Chris Gramberg as maintainers so more folks can now take care of these requests.

Thanks again for helping us with team setup,
-Masha

Comment 7

[Chris Knowles [:cknowles]]

Alright - Confirm the teams are consistent. Thank you for that - and apologies for the concern/confusion.

Clearing the NI for dmueller as we're about to finish out.

Justin - you've waited patiently.

for the ORGNAME Mozilla, Mozilla-IT, Mozilla-SRE-Deploy, Mozilla-Services, you will get both invitations referred to below. For Pocket, you will only get the GitHub invite.

You will be getting two invites. First from people.m.o invites to the group ghe_ORGNAME_users - please accept this before proceeding.
Next, from GitHub to whatever email address you have associated with your GitHub account. The invites to the ORGNAME org(s) - once you accept these and sign into GitHub you'll be a member of the org(s), and the requested teams.

If you can't find that GitHub invite, go to the following link and next to the desired organization name, there should be an option to accept an invite. https://github.com/settings/organizations

Note that invites expire after a week, and so if you need things re-sent please update this bug.

Once you’re signed into the org, there may be some changes you need to make if you use PAT/SSH/gh cli/other-tools - directions for that live here: https://wiki.mozilla.org/GitHub/GHE_SAML_User_FAQ#Alright.2C_I.27ve_SAML.27d_what_now.3F

Please let us know if there's any questions or concerns