1943364 - Avoid unecessary redux store state changes in the netmonitor

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement)

Description

[Alexandre Poirot [:ochameau]]

There is a handful of reducers in the netmonitor which are cloning the returned state object, regardless of the state being actually changed of not.
Given that the network monitor has many connected components, it will force to call mapStateToProps on all of them and trigger the selectors and the diffing algorithm of Redux on the props output.

We should do our best to only change the state when strictly necessary.
Let's try to do that for all the naive actions.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1943364 - [devtools] Avoid various unecessary state changes in the netmonitor.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1943364 - [devtools] Prevent unecessary updates when the netmonitor gets hidden.

Comment 3

[Alexandre Poirot [:ochameau]]

These two patches, with a direct comparison against m-c, report some small improvements, but on unrelated subtests...
https://perf.compare/subtests-compare-results?baseRev=616e32a73e205f2085e7147448e87ada363f144a&baseRepo=try&newRev=2530b075b0483b6e9f7e05168f099c2dfcffec1c&newRepo=try&framework=12&baseParentSignature=4763542&newParentSignature=4763542&filter_confidence=medium%2Chigh

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01a1d0f4b27f
[devtools] Avoid various unecessary state changes in the netmonitor. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/9c65c50da756
[devtools] Prevent unecessary updates when the netmonitor gets hidden. r=devtools-reviewers,jdescottes

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/01a1d0f4b27f
https://hg.mozilla.org/mozilla-central/rev/9c65c50da756