1943543 - Avoid unecessary panel resize everytime they get hidden and re-shown

Status: RESOLVED FIXED

(DevTools :: General, enhancement)

Description

[Alexandre Poirot [:ochameau]]

For now, all DevTools panels get collapsed when switching to another one, which triggers a document resize.
Panels often listen to resize event to launch updates, it may also triggers reflows automatically based on document size...

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1943543 - [devtools] Prevent unecessary updates when the netmonitor gets hidden.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1943543 - [devtools] Prevent panels from resizing when hiding and then restoring.

The deck was a flex where each panel was a flex:1 element
and using visibility collapse to make their size become 0 on hiding.

Instead always keep them full size and rely on visibility:hidden to hide them.

Note that the console is still special and involves collapsing.

Comment 3

[Phabricator Automation]

Comment on attachment 9461495 [details]
Bug 1943543 - [devtools] Prevent unecessary updates when the netmonitor gets hidden.

Revision D235414 was moved to bug 1943364. Setting attachment 9461495 [details] to obsolete.

Comment 4

[Alexandre Poirot [:ochameau]]

These patches, on top of bug 1943364 reports a 74% regression on togglePanel and 27% improvement on custom.netmonitor.close:
https://perf.compare/subtests-compare-results?baseRev=2530b075b0483b6e9f7e05168f099c2dfcffec1c&baseRepo=try&newRev=b2cddc6b72b2c4bf754ab13f517e2292342a5883&newRepo=try&framework=12&baseParentSignature=4763542&newParentSignature=4763542&filter_confidence=medium%2Chigh

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1943543 - [devtools] Prevent panels from resizing when switching from/to the web console.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd5fce018c5a
[devtools] Prevent panels from resizing when hiding and then restoring. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/cd2dd8259eba
[devtools] Prevent panels from resizing when switching from/to the web console. r=devtools-reviewers,nchevobbe

Comment 7

[agoloman]

Backed out for causing bc failures @browser_ext_devtools_panel.js.

• Backout link
• Push with failures
• Failure Log

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9fd769ef34ca
[devtools] Prevent panels from resizing when hiding and then restoring. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/214d5bcaee80
[devtools] Prevent panels from resizing when switching from/to the web console. r=devtools-reviewers,nchevobbe

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/9fd769ef34ca
https://hg.mozilla.org/mozilla-central/rev/214d5bcaee80