1943945 - Migrate parserWorker.getClosestFunctionName to use lezer

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Hubert Boma Manilla (:bomsy)]

This API is used in the mapping of frame function names, when viewing frames for an original source.

Comment 1

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1943945 - [devtools] Migrate parserWorker.getClosestFunctionName to use the codemirror parser r=#devtools

Comment 2

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1943945 - [devtools] Start caching the source text in the source editor when sources are available r=#devtools

Comment 3

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1943945 - [devtools] Increase the test coverage for original frames display name r=#devtools

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff5118acc42f
[devtools] Start caching the source text in the source editor when sources are available r=devtools-reviewers,ochameau
https://hg.mozilla.org/integration/autoland/rev/d106056f14ce
[devtools] Migrate parserWorker.getClosestFunctionName to use the codemirror parser r=perftest-reviewers,devtools-reviewers,fbilt,ochameau
https://hg.mozilla.org/integration/autoland/rev/71a3b47c69b5
[devtools] Increase the test coverage for original frames display name r=devtools-reviewers,ochameau

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ff5118acc42f
https://hg.mozilla.org/mozilla-central/rev/d106056f14ce
https://hg.mozilla.org/mozilla-central/rev/71a3b47c69b5

Comment 6

[Acasandrei Beatrice (needinfo me)]

(In reply to Pulsebot from comment #4)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff5118acc42f
[devtools] Start caching the source text in the source editor when sources
are available r=devtools-reviewers,ochameau
https://hg.mozilla.org/integration/autoland/rev/d106056f14ce
[devtools] Migrate parserWorker.getClosestFunctionName to use the codemirror
parser r=perftest-reviewers,devtools-reviewers,fbilt,ochameau
https://hg.mozilla.org/integration/autoland/rev/71a3b47c69b5
[devtools] Increase the test coverage for original frames display name
r=devtools-reviewers,ochameau

H! Do you think this changeset or Bug 1953851 (changeset 91e60430278e64bee063d5de748399ff5ca1de88) could have caused the performance regression reported below?

Perfherder has detected a devtools performance change:

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
10%	damp custom.jsdebugger.stepInNewSource.big-bundle.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	2,402.63 -> 2,645.69
6%	damp custom.jsdebugger.stepInNewSource.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	2,179.60 -> 2,311.00
3%	damp custom.jsdebugger.stepInNewSource.big-bundle.DAMP	windows11-64-24h2-shippable	e10s fission stylo webrender	1,008.80 -> 1,043.60
3%	damp custom.jsdebugger.stepInNewSource.DAMP	windows11-64-24h2-shippable	e10s fission stylo webrender	867.71 -> 895.57

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
30%	damp custom.jsdebugger.pretty-print.reload-and-pause.DAMP	macosx1470-64-shippable	e10s fission stylo webrender	6,726.90 -> 4,705.58
29%	damp custom.jsdebugger.pretty-print.reload-and-pause.DAMP	windows11-64-24h2-shippable	e10s fission stylo webrender	3,918.09 -> 2,792.60
27%	damp custom.jsdebugger.pretty-print.reload-and-pause.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	9,196.94 -> 6,684.42

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 44406

For more information on performance sheriffing please see our FAQ.

Comment 7

[Hubert Boma Manilla (:bomsy)]

The regressions on the step in and the improvements on the pretty-print tests are expected. This moves away from using the babel parser to using codemirror lezer parser.