Closed Bug 1944086 Opened 19 days ago Closed 19 days ago

[Android] Heuristic for identifying language models downloaded on the fly has regressed

Categories

(Firefox :: Translations, defect)

defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: olivia, Unassigned)

References

Details

Steps to reproduce

On an Android device:

  • Delete or else ensure no languages are downloaded (Browser Menu -> Settings -> Translations -> Download Languages)
  • Perform a translation on a language that is not downloaded / has not been translated before
  • Open the downloaded language list again (Browser Menu -> Settings -> Translations -> Download Languages)
  • Notice the language isn't in the list -> as of Bug 1940544
  • Perform a manual download on any language or hard close and reopen the app, notice the expected languages will not sync back in (divergence from bug 1940544)

Previous behavior

Downloaded language list should count models downloaded on the fly during a translation.

Workaround behavior

Performing a two way translation will sync the model to the list. For example, translate English -> French and then French -> English.

Additional notes:

I'm fairly confident the prior behavior only required a one way translation to appear as "downloaded" since when a model is downloaded the idea is the download will be going to the target language. (I could be misremembering the prior behavior; however, bug 1940544 makes me inclined to think that I'm not. I'll try to find if these behavior was ever documented in a comment somewhere.)

Occurring on release 134, but there is some oddness because I reported bug 1940544 only 19 days ago. Could a reformatting of remote settings broke an isDownloaded heuristic?

Would be related to the hasAllFilesForLanguage. GeckoView calls from here.

See Also: → 1940544

Couldn't 100% confirm if the prior behavior required one way or both ways.

Found a few QE recommendations from the past that documented some of this screen's behavior, just adding them here: bug 1862293, bug 1905684.

I'm going to resolve as WORKSFORME because I'm inclined to think I'm misremembering since the download size numbers add up correctly when counting both ways (FR -> EN + EN -> FR size).

It probably is an area we should be testing on major changes, just in case something slips through, though.

Status: NEW → RESOLVED
Closed: 19 days ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.