1944300 - HACL* consistency check failures

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Julien Cristau [:jcristau]]

Bug 1866841 modified a number of HACL* files, which causes the consistency check on CI to fail when comparing the code in nss vs github.

Comment 1

[Julien Cristau [:jcristau]]

Attachment: Bug 1944300 - revert changes to HACL* files from bug 1866841.

We expect our version of the code to be the same as HACL* revision
0f136f28935822579c244f287e1d2a1908a7e552 (modulo clang-format), but
changeset e4f466278056 "Bug 1866841 - Add Libcrux implementation of
ML-KEM 768 to FreeBL" made a number of changes that cause the
consistency check to fail.

Comment 2

[Julien Cristau [:jcristau]]

Attachment: Bug 1944300 - use `diff -u` in HACL* consistency check.

The default diff output is unreadable.

Comment 3

[Julien Cristau [:jcristau]]

Attachment: Bug 1944300 - ignore all libcrux files in run_hacl.sh

These files aren't in the version of HACL* we're comparing against.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

:franziskus, since you are the author of the regressor, bug 1866841, could you take a look?

For more information, please visit BugBot documentation.

Comment 5

[Julien Cristau [:jcristau]]

Attachment: Bug 1944300 - refactor run_hacl.sh slightly. r?nkulatova

• move the formatting and patching to the beginning of the script so we can
  patch more than dist/gcc-compatible/*
• consolidate Hacl_Ed25519.{c,h} patches from bug 1325335 into a single file

Comment 6

[Julien Cristau [:jcristau]]

Attachment: Bug 1944300 - restore alloca.h include. r?jschanck

This was initially included in 1866841; we now account for it to compare
against HACL*, to avoid regressing bug 1857190.

Comment 7

[Julien Cristau [:jcristau]]

revert changes to HACL* files from bug 1866841. r=jschanck
https://hg.mozilla.org/projects/nss/8cbd4790ab912e9560397868be096b99f8c83f11
use diff -u in HACL* consistency check. r=nkulatova
https://hg.mozilla.org/projects/nss/262378bf0a9a6cdc843e9847f3457b7bbd415f5e
ignore all libcrux files in run_hacl.sh r=nkulatova
https://hg.mozilla.org/projects/nss/c3d63aabbb4f86c870ca5ded68ca7473bfd7f582
refactor run_hacl.sh slightly. r=nkulatova
https://hg.mozilla.org/projects/nss/00d334cebb0c91079b3f40e479e3ab6bf375ddaf
restore alloca.h include. r=jschanck
https://hg.mozilla.org/projects/nss/9977a6807605fc140b28b876963fe01ae250170f