1944423 - [css-grid] Resolve grid-item’s percentage block size (with aspect-ratio) when computing grid container's intrinsic inline-size

Status: RESOLVED FIXED

(Core :: Layout: Grid, defect)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Currently, we compute only the grid column sizes when determining the grid container's intrinsic inline size [1]. We should also compute row sizes so that grid items with percentage block sizes can use the row sizes as a percentage basis.

[1] https://searchfox.org/mozilla-central/rev/a965e3c683ecc035dee1de72bd33a8d91b1203ed/layout/generic/nsGridContainerFrame.cpp#9806-9807

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1944423 Part 1 - Resolve grid row sizes when computing grid container's intrinsic inline-size.

The idea behind this patch is to allow grid items with percent-valued
block-sizes to resolve against definite grid rows and then transfer that
resolved block-size as their inline contribution to the grid container's
intrinsic inline-size.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1944423 Part 2 - Update test expectations and references.

Here are the modification to those reftests in our reftest framework. In these
sub-tests, the grid containers' widths become the same as their items' width,
and Firefox now has the same behavior as Google Chrome.

• grid-auto-min-sizing-min-content-min-size-002-ref.html: test 7, 8, and 9.
• grid-auto-min-sizing-min-content-min-size-004-ref.html: test 4 and 6.
• grid-auto-min-sizing-transferred-size-002-ref.html: test 8, 12, and 13.
• grid-auto-min-sizing-transferred-size-004-ref.html: test 4 and 6.
• grid-min-content-min-sizing-transferred-size-002-ref.html: test 8, 12, and 13.
• grid-min-content-min-sizing-transferred-size-004-ref.html: test 4 and 6.

Note: grid-auto-min-sizing-transferred-size-002.html is marked as fails, and
this patch just change those sub-tests that have behavior change introduced by
this bug.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f4933db48c8
Part 1 - Resolve grid row sizes when computing grid container's intrinsic inline-size. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/52bc4c80d65f
Part 2 - Update test expectations and references. r=dholbert

Comment 7

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/0f4933db48c8
https://hg.mozilla.org/mozilla-central/rev/52bc4c80d65f