1957244 - Enable the new multi-pass grid track sizing behavior in all channels

Status: RESOLVED FIXED

(Core :: Layout: Grid, task)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

This bug is to enable the preference layout.css.grid-multi-pass-track-sizing.enabled in all channels. Any bugs that need to be fixed before enabling this preference should block this bug (i.e., they should be listed in the "Depends on" field in this bug).

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1957244 - Enable layout.css.grid-multi-pass-track-sizing.enabled by default.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7ec3a72eb5d5
https://hg.mozilla.org/integration/autoland/rev/e4353f5fe7af
Enable layout.css.grid-multi-pass-track-sizing.enabled by default. r=dholbert

Comment 3

[Daniel Holbert [:dholbert]]

Note for sheriffs/others -- we're anticipating that this may have some impact on perf metrics, since this is enabling a spec-change which requires us to do more work during layout.

(Hopefully the impact won't be substantial, though.)

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/e4353f5fe7af

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Did you want to nominate this for the Fx143 relnotes?

Comment 8

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Did you want to nominate this for the Fx143 relnotes?

Good idea!

Release Note Request (optional, but appreciated)
[Why is this notable]: Websites using grid layout now render correctly in certain scenarios where Firefox previously ended up with the wrong layout.
[Affects Firefox for Android]: Yes
[Suggested wording]: Firefox updates the grid sizing algorithm to better align with the CSS Grid specification. Grid layouts that use percentage row sizes, or grid items containing elements with aspect ratios (such as images), will now render correctly in more cases.
[Links (documentation, blog post, etc)]: https://drafts.csswg.org/css-grid-2/#algo-grid-sizing

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Added to the Fx143 relnotes, thanks!

Comment 10

[Dipika]

Tracking MDN doc updates for this in https://github.com/mdn/content/issues/40775