1944627 - Sidebar button still present checked (pressed) after turning off sidebar revamp

Status: RESOLVED FIXED

(Firefox :: Sidebar, defect, P1)

Description

[:Gijs (he/him)]

STR:

1. open clean Firefox nightly profile
2. open Labs or the settings page where we put the new "browsing" section post-bug 1936379
3. turn on new/revamped sidebar
4. turn off

ER:
either the sidebar button stays or is removed - but if it stays, its state should correspond to whether the sidebar is open or not

AR:
the sidebar button stays but also is checked, which is confusing because the sidebar is not open.

Comment 1

[:Gijs (he/him)]

This is a recent regression, https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2c456ff06c722d1fa5c2820233da0db19b72b5c3&tochange=d9b57e2b8726c289eb9ba86c2bc81594bbfbd326 .

Looking at this also made me realize that maybe the issue is that the button starts being checked/pressed at all, when sidebar.revamp is turned on?

Based on that window, maybe bug 1938249 is the regressor?

Comment 2

[:Gijs (he/him)]

OK, confirmed the regressor is bug 1938249 - Nikki, do you have cycles to take a look?

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1938249

Comment 4

[:Gijs (he/him)]

I found some time today. :-)

Comment 5

[:Gijs (he/him)]

Attachment: Bug 1944627 - update sidebar button checked state for non-revamped sidebar cases, r?#sidebar-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef6ed1744c19
update sidebar button checked state for non-revamped sidebar cases, r=sidebar-reviewers,kcochrane

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ef6ed1744c19