1944686 - Have Suggest results use icons from TippyTopProvider rather than the ones returned via Merino

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

See bug 1944611 for additional context. Effectively, Merino has been supplying chrome:// icon URIs for results for Suggest, and when we changed the tippytop URIs in bug 1941026, we effectively broke the Suggest favicons in Nightly because the pathing stopped working.

It seems pretty brittle for Merino to be passing chrome:// URIs to the client. Merino shouldn't know or care how internal chrome:// URIs are mapped. What I suggest we do instead is have the AwesomeBar ignore the icon returned for suggest results, and attempt to use TippyTopProvider to resolve to the chrome:// URI instead. Then as clients with that patch ramp down, Merino can eventually stop passing the icon URI altogether.

Comment 1

[Drew Willcoxon :adw]

I'll take a look, thanks for raising it with me, Mike. I'll give this a P3 since I understand it's not urgent once bug 1944611 is fixed.

Comment 2

[Nan Jiang [:nanj]]

This is fixed in Merino via PR-779 and PR-780. Merino can better handle 3rd-party images now, all the TippyTop images have been pulled from Merino.