1944611 - Some Suggest results returned by Merino now have broken favicons

Status: RESOLVED FIXED

(Firefox :: Top Sites, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

It seems that for Suggest, Merino returns some icon URIs that are actually chrome:// URIs for local tippytop images:

• https://github.com/mozilla-services/merino-py/blob/197215574951ec1e8c5dbbe53ed241a30fc93fd7/merino/providers/suggest/wikipedia/provider.py#L15
• https://github.com/mozilla-services/merino-py/blob/197215574951ec1e8c5dbbe53ed241a30fc93fd7/merino/jobs/navigational_suggestions/utils.py#L27-L32

We recently moved those images in bug 1941026 so that they're accessed from chrome://browser/content/topsites/tippytop/ rather than chrome://activity-stream/content/data/content/tippytop/.

This means that for Nightly, where we did that move, these results are getting URIs that don't map to proper local images. We could update Merino to point at the new URIs, but that'd break older clients who have the old URIs. We could do UA sniffing, but that's maybe complicated.

For now, I think I can remap the local URIs to chrome://activity-stream/content/data/content/tippytop/ without moving the files back to browser/components/newtab to make things work again. That'll fix things in the short term, and not block the move happening in bug 1938452. We can then figure out how to decouple Merino from this internal notion of where icons are stored afterwards.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1944611 - Temporarily remap tippytop URIs back to chrome://activity-stream/content/data/content/tippytop/. r?jteow!

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1941026

Comment 3

[Mike Conley (:mconley) (:⚙️)]

[Tracking Requested - why for this release]:

In the event that this bug rides the trains, Suggest users on Beta will probably see some broken favicons for various results.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/202a0b27fd64
Temporarily remap tippytop URIs back to chrome://activity-stream/content/data/content/tippytop/. r=jteow,home-newtab-reviewers,thecount

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages

Backout link: https://hg.mozilla.org/integration/autoland/rev/63f481a1fc8430e5da7026fe596df782b4d69448

Push with failures

Failure log -> ERROR - package> ERROR: The following duplicated files are not allowed:

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3689d3cd2bfb
Temporarily remap tippytop URIs back to chrome://activity-stream/content/data/content/tippytop/. r=jteow,home-newtab-reviewers,thecount

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/3689d3cd2bfb