1944694 - Consider expanding Glean's architecture detection

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task, P2)

Description

[Chris H-C :chutten|PTO (back July 13)]

Glean's client_info.architecture doesn't have the same fine resolution as Legacy Telemetry's environment.build.architecture.

Glean's value comes from rustc supplying us with the target_arch cfg attribute. At present we detect aarch64, arm, x86, and x86_64, letting the rest be Unknown.

Legacy's value comes from, eventually, the sysinfo define _PR_SI_ARCHITECTURE which has a lot of different values.

A 1-day 1% sample of "main" pings comes up with the following reported values (by ping count):

x86-64	3,638,856	
x86	349,965	
aarch64	108,900	
arm	3,607	
amd64	25	
ppc64	5	
riscv64	5

Looks like maybe we look into amd64, ppc64, and riscv64? I don't know what the full list of values for target_arch are. The docs supply a list of examples which includes powerpc64 which we could add, I suppose.

ni?janerik -- is there a way to know what target_arch values there are, or at least the ones we're likely to see in a Firefox Desktop build? Are they discernable from the Cargo.toml or some other build config?

Comment 1

[Jan-Erik Rediger [:janerik]]

Teeechnically target_arch could be anything, but should most likely somewhat match the first part of the platform target (see https://doc.rust-lang.org/nightly/rustc/platform-support.html).

Our compile-time hardcoded list is based on the platforms crate.
We didn't use that crate directly and instead copied just the minimal parts we needed because ... we didn't plan on supporting much more initially!
They do have a nice list though and we could extend our code based on that.
Essentially just adding the few more architectures you listed above from the 1% sample.

Comment 2

[Chris H-C :chutten|PTO (back July 13)]

Hrm, no amd64, guess it gets rolled into x86_64. Probably fine.

Comment 3

[BMO Github Automation]

Attachment: [mozilla/glean] bug 1944694 - Add more target_arch based on those seen in the Legacy Telemetry Environment (#3058)

Comment 4

[Chris H-C :chutten|PTO (back July 13)]

chutten merged PR [mozilla/glean]: bug 1944694 - Add more target_arch based on those seen in the Legacy Telemetry Environment (#3058) in 5d533c0.

Gonna leave this open to remind us to increment Glean Count by one when a release with this code is vendored into m-c.

Comment 5

[Chris H-C :chutten|PTO (back July 13)]

Attachment: Bug 1944694 - Account for Glean SDK expanded architecture detection r?TravisLong

Comment 6

[Chris H-C :chutten|PTO (back July 13)]

Attachment: Bug 1944694 - Fix accounting for already-migrated default search engine probes r?TravisLong

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d95bc64afa2
Account for Glean SDK expanded architecture detection r=TravisLong DONTBUILD
https://hg.mozilla.org/integration/autoland/rev/77694b81d50c
Fix accounting for already-migrated default search engine probes r=TravisLong DONTBUILD

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/0d95bc64afa2
https://hg.mozilla.org/mozilla-central/rev/77694b81d50c