1944718 - NTP body content shifts when scrolling up with browser.newtabpage.activity-stream.showSearch = false

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Asif Youssuff]

Attachment: jumpy ntp

Steps to reproduce:

1. Set browser.newtabpage.activity-stream.showSearch to false
2. open new tab
3. scroll down
4. scroll up

What happens:

The top sites and below jump up.

Expected result:

There should be no jumpiness.

Screencast attached.

Comment 1

[Asif Youssuff]

Attachment: jumpy ntp

Comment 2

[Scott [:thecount] Downe]

Attachment: Bug 1944718 - Newtab fixing fixed search position if search is turned off

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29067c6838d0
Newtab fixing fixed search position if search is turned off r=home-newtab-reviewers,maxx

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/29067c6838d0

Comment 7

[Reem Hamoui]

Attachment: Bug 1944718 - Newtab fixing fixed search position if search is turned off

Original Revision: https://phabricator.services.mozilla.com/D236891

Comment 8

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Content shifting when search is turned off
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Steps in bugzilla
• Risk associated with taking this patch: low
• Explanation of risk level: It's a small block of JS change
• String changes made/needed: None
• Is Android affected?: no

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/4b30d3cfd02c

Comment 10

[Timea Zsoldos [:tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 136.0a1 (2025.01.29) on Windows 11.
I can confirm this issue is fixed, I verified using Firefox 136.0.4 and Firefox 137.0.1 on Windows 11, Ubuntu 22 and on macOS 10.15.