1944733 - Tab overflow menu: "move group to new window" fails when caller window has only one tab

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P2)

Description

[DJ (:dwalker)]

STR

1. add a tab group and an ungrouped tab to a window
2. open a new window with only a single tab
3. open TOM on the new window
4. right click the tab group in the list and select "move to new window"

Expected: The group is moved to a new window

Actual: TypeError: can't access property "addEventListener", newWindow is null

Comment 1

[DJ (:dwalker)]

Attachment: Bug 1944733 - fix caller window for open-tab-group-context-menu_moveToNewWindow. r?dao,jswinarton

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e12f5d5b652
fix caller window for open-tab-group-context-menu_moveToNewWindow. r=dao,tabbrowser-reviewers

Comment 3

[Atila Butkovits]

Backed out for causing failures at browser_tab_manager_groups.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/6c0447897a6378c6574dad39395ca80e29f7fe5c

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=2e12f5d5b65260ed1627c03c6dc2d4e87ff560a3&selectedTaskRun=YuAaW2FRSVGm0Zjpx0o5GQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=492490483&repo=autoland&lineNumber=15846

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5784d0c91aea
fix caller window for open-tab-group-context-menu_moveToNewWindow. r=dao,tabbrowser-reviewers

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5784d0c91aea