1944842 - Sidebar can get into scenario where it's expanded but vertical tabs aren't showing labels

Status: ASSIGNED

(Firefox :: Sidebar, defect, P1)

Description

[Kelly Cochrane [:kcochrane]]

Attachment: Screenshot 2025-01-30 at 12.28.16.png

STR:
Enable vertical tabs in about:preferences that will also enable the new sidebar
Toggle the sidebar toolbar button until it expands the sidebar
Disable the new sidebar while still in expanded state
Reenable vertical tabs

This looks to be the same issue we were seeing in bug 1936839.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1938249

:nsharpley, since you are the author of the regressor, bug 1938249, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1930199

Comment 3

[Jonathan Sudiaman [:jsudiaman]]

Attachment: Bug 1944842 - Sidebar can get into scenario where it's expanded but vertical tabs aren't showing labels r?#sidebar-reviewers!

Disabling revamp means that we also set expanded to false. However, since revamp is disabled, these changes are not reflected back to sidebar-main, resulting in a weird mismatch between SidebarState and what the launcher sees.

This was partially fixed by the lines in initializeState(), which updates the tab container, but not the launcher. This generalizes the solution to ensure that all components are kept up to date.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85ef05d78aa4
Sidebar can get into scenario where it's expanded but vertical tabs aren't showing labels r=sidebar-reviewers,sfoster

Comment 5

[agoloman]

Backed out for causing bc failures @browser_resize_sidebar.js.

• Backout link
• Push with failures
• Failure Log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fed22f8c018a
Sidebar can get into scenario where it's expanded but vertical tabs aren't showing labels r=sidebar-reviewers,sfoster

Comment 7

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in browser_toolbar_sidebar_button.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/sidebar/tests/browser/browser_toolbar_sidebar_button.js | Uncaught exception in test bound test_expanded_state_for_always_show - Toolbar button expanded attribute is absent. - timed out after 50 tries.