1944944 - A11y Audit for Full-Page ARIA Attribute Translations

Status: RESOLVED FIXED

(Firefox :: Translations, task)

Description

[Erik Nordin [:nordzilla]]

Description

At your earliest convenience, I would love for the A11y team to just do a quick audit of the translatable ARIA attributes that we handle in Full Page Translations.

In particular I would like to know:

1. Are there any that we're missing that we should be translating.
2. Are there any that we are currently translating that would be better if we left alone.

Thank you!

How do we test this?

No specific testing is necessary. I just want reassurance from a11y experts that we're doing the correct things.

When will this ship?

This is already in production. But that doesn't mean we can't make improvements if this review determines that any are warranted! :)

Comment 1

[❌ Anna Yeddi [:ayeddi] ❌ On leave until 2027-01-04]

Apologies for the delay in replying to you!

Per ARIA spec, the following attributes are expected to be translated when a page is localized:

1. aria-braillelabel - keep
2. aria-brailleroledescription - keep but fix the typo in the code
3. aria-colindextext - add
4. aria-description - keep
5. aria-label - keep
6. aria-placeholder - keep
7. aria-roledescription - keep
8. aria-rowindextext - add
9. aria-valuetext - keep

HTML translatable attributes:

1. abbr on <th> elements
2. alt - keep with the following additions/edits:
   1. we'd need to add the <image> tag to the <img> tag too
   2. add <area>
   3. I think we could remove the limit for image type <input> elements only, and keep general <input> tag without conditions (per the translatable HTML spec)
3. content on <meta> tags, per spec: "if the name attribute specifies a metadata name whose value is known to be translatable" - add
4. download on <a> and <area> - add
5. label - keep with the following additions:
   1. we'd need to add the <optgroup> and <option> tag to the <track> tag too
6. lang on any tag, per spec: "must be "translated" to match the language used in the translation" - add
7. placeholder - keep with the following additions/edits:
   1. we'd need to add the <input> and <textarea> tags so we avoid checking all other tags for it, esp. when poor markup is provided by the website autors
8. srcdocs on <iframe>, per spec: "must be parsed and recursively processed" - add
9. style on any tag, per spec: "must be parsed and recursively processed (e.g. for the values of 'content' properties)" - add
10. value on <input> - keep:
    1. interestingly, per spec, only type=button and type=reset are included in the translatable properties. Submit seems to be a valid example of something that may be translated too, but the HTML WHATWG does not mention it...

I am not sure, if accessKey is localizeable, in general? The available keyboard may be different, i.e. for someone using Cyrillic or Japanese alphabets... I'd follow the L18n team guidance on this one

XUL tags - do we target those too? AFAIK they're only used in Fx chrome UI, so LMK if you'd need input for those too.

Comment 2

[Erik Nordin [:nordzilla]]

In its current state, this will make an excellent Good First Bug for someone to try.

The location of the code changes is mentioned in the top-level description, and the instructions/analysis from Anna are extremely well laid out and clear.

Comment 3

[anitah mugabe]

I would like to give this a shot

Comment 4

[Erik Nordin [:nordzilla]]

Please give it a try.

Feel free to reach out here, in the Matrix channel, or by submitting a work-in-progress patch via moz-phab submit --wip if you want early feedback on some code changes.

Comment 5

[Folarin Kamar]

@nordzilla, I wanted to know if contributions has started for this bug, or should I pick up another bug with good first bug tag

Comment 6

[Isaac Briandt]

Attachment: Bug 1944944 - Update code to align with A11y Audit for Full-Page ARIA Attribute Translations r=nordzilla

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d83bc8b72f1c
Update code to align with A11y Audit for Full-Page ARIA Attribute Translations r=nordzilla,translations-reviewers

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d83bc8b72f1c