1959127 - Translate "placeholder" attributes on <textarea> elements

Status: RESOLVED FIXED

(Firefox :: Translations, enhancement)

Description

[Erik Nordin [:nordzilla]]

Background

In Bug 1944944 we audited our attribute translations, creating a more detailed list of attributes to translate according to specifications.

In the patch associated with Bug 1944944, all of the trivial additions and removals were handled, and any changes that were more involved are now being filed as follow-ups.

---

Description

We want to translate the "placeholder" attribute on <textarea> elements. However, in order to do this, we need to make an exception for <textarea> being excluded from translation.

We have a list of excluded tags that help inform our algorithm on which nodes to skip. TEXTAREA is included in here, which is good, because we don't want to translate the TEXTAREA's content.

However, its exclusion in this list is also causing our attribute translations to skip over these types of elements, even when they have placeholders that are translatable.

We should determine a way to allow attribute translations on a <textarea> placeholder, while still excluding it from regular translation.

---

Steps to Implement

• Determine a strategy to translate the placeholder attribute. This could mean making two lists, one for attribute excluded nodes, and one for content excluded nodes. Or perhaps making the existing list more nuanced to be able to distinguish between the two purposes.
• Add "placeholder" to the translatable attributes for <textarea> elements.

---

Tests to Implement

• Create test cases to ensure <textarea> placeholders are translated, and that neither <textarea> content nor other attributes on the <textarea> are translated.

Comment 1

[Erik Nordin [:nordzilla]]

Isaac, just sending you an NI to make sure you saw this in my comment on D243241.

Comment 2

[Isaac Briandt]

Oh... I think I missed the notification. Right, I have seen it now. I will work on it asap. Thank you Erik!

Comment 3

[Isaac Briandt]

Attachment: Bug 1959127 - [translations] Translate placeholder attributes on <textarea> r=nordzilla

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64268c7b881d
[translations] Translate placeholder attributes on <textarea> r=nordzilla,translations-reviewers

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/64268c7b881d