1944958 - UpdateUtils attempts migration during xpcshell tests

Status: RESOLVED INVALID

(Toolkit :: Application Update, task)

Description

[Beth Rennie [:beth] (she/her)]

I managed to trigger UpdateUtils to attempt a migration of its configuration file inside an xpcshell test during unrelated work (see-also bug 1941961, where I changed some aspects of Nimbus initialization). This got caught by a search test that does not allow console.log statements:

[task 2025-01-30T18:13:04.755Z] 18:13:04  WARNING -  TEST-UNEXPECTED-FAIL | xpcshell.toml:toolkit/components/search/tests/xpcshell/test_defaultEngine.js | test_switch_with_invalid_overriddenBy - [test_switch_with_invalid_overriddenBy : 614] Unexpected console message received during test: readUpdateConfig: Unable to read app update configuration file. Exception:  - false == true

According to :bytesized, this is maybe unnecessary work that could be avoided.

Comment 1

[Robin Steuber (she/her) [:bytesized]]

Oh. I was thinking that with update disabled, we really shouldn't be doing any of that stuff anyways so it's weird that we'd be logging about it. But we access UpdateUtils directly in TelemetryEnvironment.sys.mjs, querying values from the update config. So, this code does actually just need to run at this point.

Sorry.