1945118 - Sometimes tabs cannot be moved to a new position

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: tab_not_move.gif

Found in

• 136.0a1 (2025-01-31)

Affected versions

• 136.0a1 (2025-01-31)

Tested platforms

• Affected platforms: Windows 10x64, macOS 12, Ubuntu 24
• Unaffected platforms: none

Steps to reproduce

1. Open the uploaded profile (link) and move the middle tab to the right.

Expected result

• The tab is moved.

Actual result

• The tab is not moved.

Regression range

• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b51f2095c1b47b6abacef716195ca3c3c5b1e14f&tochange=bb54bd88c1ec311ddef53f868e2ad6b31305a1d7

Additional notes

• Attached a screen recording.

Comment 1

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Hello Dao! It seems that mozregression points at bug 1944844. Can you please have a look? Thank you!

Comment 2

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: tab_not_move_0.gif

Sorry for the spam. It seems that this can be easily reproduced on a new profile just by dragging the first tab after the second one.

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 1945118 - Revert change from bug 1944844 and fix differently, by having #triggerDragOverCreateGroup update dragData. r=dwalker,jswinarton

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b862eba09e7a
Revert change from bug 1944844 and fix differently, by having #triggerDragOverCreateGroup update dragData. r=dwalker,jswinarton,tabbrowser-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/ca3ce1c36b37
Revert change from bug 1944844 and fix differently, by having #triggerDragOverCreateGroup update dragData. r=dwalker,jswinarton,tabbrowser-reviewers

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/ca3ce1c36b37

Comment 7

[Rares Doghi, Desktop QA]

This issue is Verified as fixed in our latest Nightly Build 136.0a1 (2025-01-31)

Comment 8

[amarc]

https://hg.mozilla.org/mozilla-central/rev/b862eba09e7a