1946339 - Dragged tab misplaced by one position when dropping after grouping indicator disappears

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P2)

Description

[Kestrel]

Attachment: Tab drops in wrong position after grouping indicator disappears

STR:

1. Drag a tab and move it multiple positions away on latest Nightly 137.0a1 (2025-02-05) with browser.tabs.groups.enabled = true.
2. Before dropping, make sure the grouping indicator appears and then slowly move until it disappears.
3. Drop the tab.

Expected:
Drops in current location.

Actual:
Drops offset one position away.

Not fixed by Bug 1945118.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2361e3eb1d64e007b626427992edfbf5662214b5&tochange=581e4f9d91fd7af32f4f65d2673f23acab9df927

Regressed by Bug 1944844.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:dao, since you are the author of the regressor, bug 1944844, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1946339 - Fix stability of group creation indicator. r=jswinarton,dwalker

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3790755d3b4c
Fix stability of group creation indicator. r=jswinarton,tabbrowser-reviewers

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/3790755d3b4c

Comment 5

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly 137.0a1 (2025-02-25)