1945146 - List all tabs no longer automatically scrolls to current tab

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[Iain Gatt]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:136.0) Gecko/20100101 Firefox/136.0

Steps to reproduce:

Open the List all tabs drop down menu with enough tabs to include a scrollbar

Select a tab at the bottom of the list (not visible without scrolling)

Open List all tabs again

Actual results:

List all tabs scrollbar is at top, non-scrolled position.

Expected results:

List all tabs scrollbar should have automatically scrolled to show the currently selected tab.

Comment 1

[Iain Gatt]

Regression details

2025-01-31T12:54:50.290000: INFO : application_name: Firefox
2025-01-31T12:54:50.290000: INFO : application_remotingname: firefox-default
2025-01-31T12:54:50.290000: INFO : application_repository: https://hg.mozilla.org/integration/autoland
2025-01-31T12:54:50.290000: INFO : application_vendor: Mozilla
2025-01-31T12:54:50.290000: INFO : application_version: 136.0a1
2025-01-31T12:54:50.291000: INFO : platform_buildid: 20250125005154
2025-01-31T12:54:50.291000: INFO : platform_changeset: 5da003458646c735eda817750b646e6ef556305c
2025-01-31T12:54:50.291000: INFO : platform_repository: https://hg.mozilla.org/integration/autoland
2025-01-31T12:54:50.291000: INFO : platform_version: 136.0a1
2025-01-31T12:55:13.757000: INFO : Narrowed integration regression window from [8a8fce22, f36f760e] (3 builds) to [8a8fce22, 5da00345] (2 builds) (~1 steps left)
2025-01-31T12:55:13.764000: DEBUG : Starting merge handling...
2025-01-31T12:55:13.764000: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=5da003458646c735eda817750b646e6ef556305c&full=1
2025-01-31T12:55:13.764000: DEBUG : redo: attempt 1/3
2025-01-31T12:55:13.764000: DEBUG : redo: retry: calling _default_get with args: ('https://hg.mozilla.org/integration/autoland/json-pushes?changeset=5da003458646c735eda817750b646e6ef556305c&full=1',), kwargs: {}, attempt #1
2025-01-31T12:55:13.769000: DEBUG : urllib3.connectionpool: Resetting dropped connection: hg.mozilla.org
2025-01-31T12:55:15.172000: DEBUG : urllib3.connectionpool: https://hg.mozilla.org:443 "GET /integration/autoland/json-pushes?changeset=5da003458646c735eda817750b646e6ef556305c&full=1 HTTP/11" 200 None
2025-01-31T12:55:15.228000: DEBUG : Found commit message:
Bug 1940269 - Place a "Show more" button in tab overflow menu in tab groups section if there's more than 6 tab groups. r=dwalker,fluent-reviewers,tabbrowser-reviewers,bolsson

Differential Revision: https://phabricator.services.mozilla.com/D235422

2025-01-31T12:55:15.228000: DEBUG : Did not find a branch, checking all integration branches
2025-01-31T12:55:15.230000: INFO : The bisection is done.
2025-01-31T12:55:15.231000: INFO : Stopped

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:dao, since you are the author of the regressor, bug 1940269, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Dão Gottwald [:dao]]

This was an intentional decision. We're adding tab groups to the top of the list, and want to ensure they're not scrolled out of view when opening this menu. Scrolling to the selected tab was considered less important because it may not actually help the user find the tab they're looking for.

Comment 4

[Dão Gottwald [:dao]]

We've decided to revert this in bug 1946318.

Comment 5

[Dão Gottwald [:dao]]

Attachment: Bug 1945146 - Restore scrolling to the selected tab in the list all tabs menu (patch for beta uplift). r?dwalker,jswinarton

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1940269

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:dao, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox136 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 9465219 [details]
Bug 1945146 - Restore scrolling to the selected tab in the list all tabs menu (patch for beta uplift). r?dwalker,jswinarton

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: see comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: see comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial fix, reverting previous removal of this code
• String changes made/needed:
• Is Android affected?: No

Comment 10

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest 137.0a1 (2025-02-11)

Comment 11

[Dão Gottwald [:dao]]

Hey Donal, why was the approval flag reset? This should be ready to land from my perspective, the only missing piece was QA verification which happened earlier today.

Comment 12

[Donal Meehan [:dmeehan]]

Hey Dao, the patch will get beta uplift approval and I plan on taking it later today for 136.0b6.
It was never approved by release management so I put it back to pending. It was not rejected.

Comment 13

[Dão Gottwald [:dao]]

Ah, okay! Just seeing now that the bot approved the patch which seems weird; I didn't know that's a thing that could happen.

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/ee763fb1edfe

Comment 15

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest Beta build 136.0b6 (64-bit).