1946318 - Make the tab groups section in the tab overflow menu include tab groups from the current window

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[Dão Gottwald [:dao]]

We've heard from people getting confused about where to find their tab groups, as the "Tab groups" section in the tab manager only lists groups from other windows and saved groups, and groups from the current window are in the longer list below (which can overflow, so groups may be scrolled out of view). Seems like we need to either improve the labeling, or duplicate groups from the current window in the "Tab Groups" section and thus make that list comprehensive.

Comment 1

[Amy Lee [:amylee] UX]

Hi,
I've attached a spec that updates the "Tab groups" section to include tab groups opened in the current window. There are also some small UX adjustments as well.

https://www.figma.com/design/f6J2lH6XDxLxyzOLr2E8oE/Tab-Grouping-Spec?node-id=16894-51809&t=hUYmAy9FEn7SbiGM-1

Comment 2

[Dão Gottwald [:dao]]

Attachment: WIP: Bug 1946318 - Show groups from all windows in groups list, implement sub view for showing all groups, and add header to tabs list.

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 1946318 - Show groups from all windows in groups list, implement sub view for showing all groups, and add header to tabs list. r?dwalker,jswinarton

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9fe6747802c0
Show groups from all windows in groups list, implement sub view for showing all groups, and add header to tabs list. r=dwalker,fluent-reviewers,tabbrowser-reviewers,bolsson

Comment 5

[Atila Butkovits]

Backed out for causing failures at browser_tab_manager_groups.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/acc7fe11b0a7357210ed019e976ba117f3f1a488

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=CGYm2KidRSWooWP5-xgR-w.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=9fe6747802c0e3d6459b7a97f90aa2cfd4d6e197

Failure log: https://treeherder.mozilla.org/logviewer?job_id=493970865&repo=autoland&lineNumber=8266

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19705cb38b7e
Show groups from all windows in groups list, implement sub view for showing all groups, and add header to tabs list. r=dwalker,fluent-reviewers,tabbrowser-reviewers,bolsson

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/19705cb38b7e