Closed Bug 1945167 Opened 10 months ago Closed 9 months ago

Perma browser/base/content/test/performance/browser_windowopen.js | unexpected 1 changed rects: ({x1:216, x2:231, y1:56, y2:71, w:16, h:16}), window width: 1280 - when Gecko 136 merges to beta on 2025-02-03

Categories

(Toolkit :: Performance Monitoring, defect)

Product:
Toolkit
Component:
Performance Monitoring
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
137 Branch
Tracking Flags:
Tracking Status
firefox-esr115 --- unaffected
firefox-esr128 --- unaffected
firefox134 --- unaffected
firefox135 --- unaffected
firefox136 + fixed
firefox137 --- verified

People

(Reporter: SerbanS, Assigned: daisuke)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1945167: Skip browser_windowopen.js test if early_beta_or_earlier
48 bytes, text/x-phabricator-request
Details | Review

Central-as-beta-simulation

How to run these simulations

Failure log

[task 2025-01-31T11:09:53.458Z] 11:09:53     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_flicker.js | unexpected changed rect: ({x1:221, x2:236, y1:56, y2:71, w:16, h:16}), window width: 1280 - 
[task 2025-01-31T11:09:53.458Z] 11:09:53     INFO - Stack trace:
[task 2025-01-31T11:09:53.458Z] 11:09:53     INFO - chrome://mochikit/content/browser-test.js:test_ok:1599
[task 2025-01-31T11:09:53.459Z] 11:09:53     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_startup_flicker.js:rects<:54
[task 2025-01-31T11:09:53.459Z] 11:09:53     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_startup_flicker.js:null:37
[task 2025-01-31T11:09:53.459Z] 11:09:53     INFO - chrome://mochikit/content/browser-test.js:handleTask:1147
[task 2025-01-31T11:09:53.459Z] 11:09:53     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1219
[task 2025-01-31T11:09:53.459Z] 11:09:53     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1360
[task 2025-01-31T11:09:53.459Z] 11:09:53     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1136
[task 2025-01-31T11:09:53.459Z] 11:09:53     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
<...>
[task 2025-01-31T11:09:53.527Z] 11:09:53     INFO - Not taking screenshot here: see the one that was previously logged
[task 2025-01-31T11:09:53.528Z] 11:09:53     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_flicker.js | should have 0 unknown flickering areas - Got 1, expected +0
[task 2025-01-31T11:09:53.529Z] 11:09:53     INFO - Stack trace:
[task 2025-01-31T11:09:53.529Z] 11:09:53     INFO - chrome://mochikit/content/browser-test.js:test_is:1627
[task 2025-01-31T11:09:53.529Z] 11:09:53     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_startup_flicker.js:null:71
[task 2025-01-31T11:09:53.529Z] 11:09:53     INFO - chrome://mochikit/content/browser-test.js:handleTask:1147
[task 2025-01-31T11:09:53.529Z] 11:09:53     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1219
[task 2025-01-31T11:09:53.530Z] 11:09:53     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1360
[task 2025-01-31T11:09:53.530Z] 11:09:53     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1136
[task 2025-01-31T11:09:53.530Z] 11:09:53     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2025-01-31T11:09:53.530Z] 11:09:53     INFO - Leaving test bound 
[task 2025-01-31T11:09:54.027Z] 11:09:54     INFO - GECKO(4018) | MEMORY STAT | vsize 3349MB | residentFast 557MB | heapAllocated 312MB
[task 2025-01-31T11:09:54.028Z] 11:09:54     INFO - TEST-OK | browser/base/content/test/performance/browser_startup_flicker.js | took 1447ms

Hi Jonathan! Could you please take a look at this? Could this be triggered by your latest changes from Bug 1944016?

Thank you!

Flags: needinfo?(jsudiaman)

Looking at the screenshots from the test log, the flicker is a looking glass icon in the urlbar that gets replaced with an icon of the Google logo.

The test does not run for Nightly. The mentioned search bar changes named ScotchBonnet are enabled in Nightly, early Beta and DevEdition. The differences here is for the favicon of the search engine. Such failures have been observed in the past for DevEdition builds and are caused by either the additional button (Developer Tools) in the Toolbar or a slightly different UI style.

The test ran on Windows 11 22H2 today, the previous run on Tuesday was with Windows 24H2 and did not hit this issue. We will likely switch back to Windows 11 24H2 later next week.

Recommendation: Wait if the issue persists.

tracking-firefox136: ? → +
Flags: needinfo?(jsudiaman)
Keywords: regression
Regressed by: 1923381

@florian yes, sorry, in this case was also this failures associated. Here it's also another snippet from the log:

[task 2025-01-31T12:35:04.028Z] 12:35:04     INFO - TEST-PASS | browser/base/content/test/performance/browser_windowopen.js | bug 1421463 - reload toolbar icon shouldn't flicker, ({x1:89, x2:102, y1:57, y2:70, w:14, h:14}), window width: 1280 - 
[task 2025-01-31T12:35:04.028Z] 12:35:04     INFO - Buffered messages finished
[task 2025-01-31T12:35:04.029Z] 12:35:04     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_windowopen.js | unexpected 1 changed rects: ({x1:216, x2:231, y1:56, y2:71, w:16, h:16}), window width: 1280 - 
[task 2025-01-31T12:35:04.029Z] 12:35:04     INFO - Stack trace:
[task 2025-01-31T12:35:04.029Z] 12:35:04     INFO - chrome://mochikit/content/browser-test.js:test_ok:1599
[task 2025-01-31T12:35:04.031Z] 12:35:04     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/head.js:reportUnexpectedFlicker:664
[task 2025-01-31T12:35:04.031Z] 12:35:04     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/head.js:withPerfObserver:723
[task 2025-01-31T12:35:04.031Z] 12:35:04     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_windowopen.js:null:115
[task 2025-01-31T12:35:04.031Z] 12:35:04     INFO - chrome://mochikit/content/browser-test.js:handleTask:1147
[task 2025-01-31T12:35:04.031Z] 12:35:04     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1219
[task 2025-01-31T12:35:04.031Z] 12:35:04     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1360
[task 2025-01-31T12:35:04.031Z] 12:35:04     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1136
[task 2025-01-31T12:35:04.031Z] 12:35:04     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
<...>
[task 2025-01-31T12:35:04.173Z] 12:35:04     INFO - Not taking screenshot here: see the one that was previously logged
[task 2025-01-31T12:35:04.175Z] 12:35:04     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_windowopen.js | should have 0 unknown flickering areas - Got 1, expected +0
[task 2025-01-31T12:35:04.175Z] 12:35:04     INFO - Stack trace:
[task 2025-01-31T12:35:04.175Z] 12:35:04     INFO - chrome://mochikit/content/browser-test.js:test_is:1627
[task 2025-01-31T12:35:04.175Z] 12:35:04     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/head.js:reportUnexpectedFlicker:680
[task 2025-01-31T12:35:04.175Z] 12:35:04     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/head.js:withPerfObserver:723
[task 2025-01-31T12:35:04.175Z] 12:35:04     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_windowopen.js:null:115
[task 2025-01-31T12:35:04.175Z] 12:35:04     INFO - chrome://mochikit/content/browser-test.js:handleTask:1147
[task 2025-01-31T12:35:04.175Z] 12:35:04     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1219
[task 2025-01-31T12:35:04.175Z] 12:35:04     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1360
[task 2025-01-31T12:35:04.175Z] 12:35:04     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1136
[task 2025-01-31T12:35:04.175Z] 12:35:04     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2025-01-31T12:35:04.177Z] 12:35:04     INFO - Console message: [JavaScript Warning: "Layout was forced before the page was fully loaded. If stylesheets are not yet loaded this may cause a flash of unstyled content." {file: "about:newtab" line: 0}]
[task 2025-01-31T12:35:04.177Z] 12:35:04     INFO - Leaving test bound 
[task 2025-01-31T12:35:04.410Z] 12:35:04     INFO - GECKO(8772) | MEMORY STAT | vsize 2112816MB | vsizeMaxContiguous 68427242MB | residentFast 682MB | heapAllocated 460MB
[task 2025-01-31T12:35:04.413Z] 12:35:04     INFO - TEST-OK | browser/base/content/test/performance/browser_windowopen.js | took 1282ms

:daisuke, since you are the author of the regressor, bug 1923381, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Flags: needinfo?(daisuke)
Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Flags: needinfo?(daisuke)

Disabling for beta makes sense especially if it's already disabled on nightly, but:

  • the entire test should not be disabled for a single unexpected flicker, these tests contain a list of exceptions for known bugs.
  • I see nothing in bug 1936557 that indicates fixing the regression is being worked on, which is worrying.
Flags: needinfo?(daisuke)

Hi, after uploading your patch the browser_windowopen.js problem is over, but there's still this , could you please take a look? Thanks.
Failure log

(In reply to amarc from comment #8)

Hi, after uploading your patch the browser_windowopen.js problem is over, but there's still this , could you please take a look? Thanks.
Failure log

Thank you very much, :amarc!
Yes, I will. If don't mind, could you file the bug??

Flags: needinfo?(daisuke)
See Also: → 1945698
See Also: → 1936557

Dale, would you be able to look at this patch soon? This is coloring the beta treeherder in orange :-) Thanks!

Flags: needinfo?(dharvey)

Set release status flags based on info from the regressing bug 1923381

status-firefox137: --- → affected
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/becb5a007f62 Skip browser_windowopen.js test if early_beta_or_earlier r=daleharvey

https://hg.mozilla.org/mozilla-central/rev/becb5a007f62

Status: ASSIGNED → RESOLVED
Closed: 9 months ago
status-firefox137: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch

The patch landed in nightly and beta is affected.
:daisuke, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox136 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(daisuke)

test-only change, so I don't need a formal uplift request for this.
I'll push to beta later today

Flags: needinfo?(dharvey)
Flags: needinfo?(daisuke)

Verified fixed in today's central as beta simulation.

Status: RESOLVED → VERIFIED
status-firefox137: fixed → verified
Regressions: 1945771
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: