1945261 - Support dependency descriptor RTP extension

Status: VERIFIED FIXED

(Core :: WebRTC: Signaling, enhancement, P1)

Description

[Nico Grunbaum [:ng, @chew:mozilla.org]]

We should add the DD RTP header extension for simulcast / SVC.

Comment 1

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1945261 - add dependency descriptor rtp header extension;r?pehrsons,bwc

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad7e19656a41
add dependency descriptor rtp header extension;r=pehrsons,bwc

Comment 3

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/ad7e19656a41

Comment 4

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1945261 - add dependency descriptor rtp header extension;r?pehrsons,bwc

Original Revision: https://phabricator.services.mozilla.com/D236425

Comment 5

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: AV1 simulcast will not work with all media servers, e.g. jitsi which uses AV1 by default
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Go to meet.jit.si and create a room. Add 3 participants, e.g. from one instance each from Firefox Release, Chrome Release and the tested Firefox. The two participants not being on the tested Firefox may also be run on a separate machine. Check that video from the tested Firefox is received by the other participants for a few minutes straight. The network should be good to exclude video problems related to bandwidth limitations or packet loss.
• Risk associated with taking this patch: Low
• Explanation of risk level: Adds an RTP header extension. Main risk is in negotiation of the extension and in the libwebrtc implementation. The former has been stable for years, the latter has had plenty of bake time in libwebrtc as part of Chrome and Safari, among others.
• String changes made/needed: None
• Is Android affected?: yes

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/123ec50188d6

Comment 7

[Raluca Popovici, Desktop QA]

Verified as fixed with the following:

1. Meeting Jitsi(~20m):
   Participant 1 MacOS 13.2.1 - Firefox Beta 136.0b3 (treeherder build)
   Participant 2 Win 11 - Chrome release
   Participant 3 Win 10 - Firefox Release
2. Meeting Jitsi(~30m):
   Participant 1 MacOS 13.2.1 - latest Nightly
   Participant 2 Win 11 - Chrome release
   Participant 3 Win 10 - Firefox Release
3. Meeting Jitsi(~10m):
   Participant 1 Win 10 - Firefox Beta 136.0b3 (treeherder build)
   Participant 2 MacOS 13.2.1 - Firefox Release
   Participant 2 Win 11 - Chrome release
4. Meeting Jitsi(~10m):
   Participant 1 Win 10 - latest Nightly
   Participant 2 MacOS 13.2.1 - Firefox Release
   Participant 3 Win 11 - Chrome release
5. Meeting Jitsi(~10m):
   Participant 1 Ubuntu 24 - Firefox Beta 136.0b3 (treeherder build)
   Participant 2 MacOS 13.2.1 - Firefox Release
   Participant 3 Win 11 - Chrome release
6. Meeting Jitsi(~10m):
   Participant 1 Ubuntu 24 - latest Nightly
   Participant 2 MacOS 13.2.1 - Firefox Release
   Participant 3 Win 11 - Chrome release

Result: Video, audio and screen share worked as expected without problems related to bandwidth limitations or packet loss.