1945424 - Ctrl+Enter keyboard shortcut in address bar opens context menu on page on macOS

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: screenshot.png

[Tracking Requested - why for this release]:

This bug is a regression in Fx 134 from bug 1921811.

Steps to reproduce

1. On macOS, click to focus the address bar. (I'm using macOS 15.2 Sequoia)
2. Enter example in the address bar.
3. Press Ctrl + Enter.

Expected behavior

The address bar should expand example to https://www.example.com/ and navigate to the website.

Actual behavior

In Fx 134 and 135, the address bar does expand example to https://www.example.com/ and navigates to the website, but it also opens a context menu on page.

In Fx 136, the address bar no longer expands example or navigates to example.com (that is bug 1945422). Fx 136 now opens a context menu in the address bar instead of on the page.

Comment 1

[Chris Peterson [:cpeterson]]

@ Emilio, I bisected this regression to this pushlog for your fix for popover bug 1921811:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d2e6af4871ea04a166c453153605f2229e73e95b&tochange=42d3134758c767b29889b2a3184fc869cc184d63

Comment 2

[Marco Bonardo [:mak]]

In MacOS Sequoia they added this Ctrl+Enter shortcut to open the context menu for the highlighted element.
I'm not sure why popover changed the handling, I suppose we don't consume/preventDefault the event anymore, maybe we should be more explicit on that.
There is a "Show contextual menu" setting in system to change the shortcut, though that's not a solution for users.
The context menu also looks like the wrong one, if the urlbar is focused it should open the urlbar context menu, not the toolbar one.

Supposing we'll use Bug 1945422 to fix ctrl+enter, here we should understand how we could support the new MacOS behavior, would it require to return to cmd+enter on Mac? Afaik that was changed in Firefox 64 in Bug 237027.

Comment 3

[Marco Bonardo [:mak]]

I don't think there's any bug in Cocoa as this is new behavior in Sequoia, though I'll let the triage owner to ponder over it, I'm not sure if there's a bug in targeting as I'd expect the context menu to open on the urlbar. Feel free to move back to Address Bar in case.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Fx 136 now opens a context menu in the address bar instead of on the page.

I think this is the expected behavior, see bug 1936928 which is what fixed this... So on the widget side of things this looks good. I think the front-end could preventDefault() this event if you want to prioritize the URL canonicalization.

Comment 5

[Chris Peterson [:cpeterson]]

Note that Ctrl+Enter in the address bar doesn't open a context menu in Chrome.

Comment 6

[Mathew Hodson]

This was addressed by bug 1945422 changing the canonization shortcut to Cmd+Enter on MacOS. As of MacOS 15.1, Ctrl+Enter is a system command for opening the context menu.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1921811