1936928 - Ctrl+Enter shortcut on macOS always targets the center of the screen rather than the focused element

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

macOS has a shortcut for showing the context menu via keyboard (Ctrl+Enter), but it looks like it targets the middle of the screen rather than the focused element, which is rather broken.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

CC'ing some a11y folks because I don't know how severe this is in practice. I'm surprised nobody has noticed.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1936928 - Handle context menu key down on macOS. r=#mac-reviewers!,masayuki

This makes Ctrl+Enter work as expected to show the context menu.

Comment 3

[James Teh [:Jamie]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #1)

CC'ing some a11y folks because I don't know how severe this is in practice. I'm surprised nobody has noticed.

I'd say no one has noticed because this keyboard shortcut was only added in MacOS 15 Sequoia. For the decades prior, you just couldn't open a context menu with the keyboard unless you used VoiceOver or some other tool.

That also makes it tricky to assess the severity. If this had been MacOS functionality for a while and we never implemented it, it'd absolutely be an s2. However, it's hard to justify this being an s2 when this capability was only just added.

Comment 4

[Morgan Reschenberg [:morgan]]

I tested this for the context menu shortcut a few weeks ago and found we had the same behaviour as safari -- I'll check again to make sure that's still true, but I'm not sure we have control over what happens during this shortcut.

Update: Looks like safari launches the menu in the upper left corner consistently, regardless of focus... I think this is reasonably an S3 considering they're our ~standard for behaviour in most of these macOS cases

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:spohl, could you have a look please?

For more information, please visit BugBot documentation.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7290a2bc3b32
Handle context menu key down on macOS. r=masayuki,mstange

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7290a2bc3b32