1945451 - The address bar flickers when changing or hovering between normal and touch density modes in the Customize toolbar

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: addressbar_flicker.gif

Found in

• 136.0a1 (2025-02-02)

Affected versions

• 136.0a1 (2025-02-02)
• 135.0
• 134.0.2

Tested platforms

• Affected platforms: Windows 10x64, Ubuntu 24
• Unaffected platforms: macOS 12 (does not have the density option)

Steps to reproduce

1. Open Customize Toolbar
2. Change/ Hover between normal and touch modes.

Expected result

• The Address bar does not flicker.

Actual result

• Address bar flickers.

Regression range

• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=13537ae67079d33202b6570bb5a61d4ee652fecb&tochange=aa2b4302bdccdbfd659158479d68c4f377237e6c

Additional notes

• Attached a screen recording.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1927111, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1945451 - Avoid breaking out the urlbar while in customize mode. r=dao,mak

Density changes called directly into the urlbar input to update the
breakout. But when customizing the urlbar shouldn't break out.

That means that this code is mostly for when density is changed via
another window, or direct pref changes I guess.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca95d7d1c9ff
Avoid breaking out the urlbar while in customize mode. r=dao,urlbar-reviewers

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/ca95d7d1c9ff

Comment 5

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 137.0a1 (2025-02-13) on Windows 10x64 and Ubuntu 24.