Add accesskeys to bookmark properties

RESOLVED FIXED

Status

RESOLVED FIXED
16 years ago
14 years ago

People

(Reporter: piers, Assigned: piers)

Tracking

({access})

Trunk
access
Dependency tree / graph
Bug Flags:
blocking1.6a -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

16 years ago
Add accesskeys to bookmark properties
(Assignee)

Comment 1

16 years ago
Created attachment 115274 [details] [diff] [review]
Add accesskeys to bookmark props
(Assignee)

Updated

16 years ago
Attachment #115274 - Flags: review?(dean_tessman)

Comment 2

16 years ago
Comment on attachment 115274 [details] [diff] [review]
Add accesskeys to bookmark props

You should add accesskeys to the check boxes on the Notify tab.  They'll work,
they just don't display due to bug 68841.
Attachment #115274 - Flags: review?(dean_tessman) → review-
(Assignee)

Comment 3

16 years ago
Created attachment 115279 [details] [diff] [review]
Add accesskeys to bookmark props v2

Done, although i don't really see the point in adding checkbox accesskeys if
they
can't be used (you can't use them if you don't know what they are!!)
Attachment #115274 - Attachment is obsolete: true
(Assignee)

Updated

16 years ago
Attachment #115279 - Flags: review?(dean_tessman)

Comment 4

16 years ago
Comment on attachment 115279 [details] [diff] [review]
Add accesskeys to bookmark props v2

Looks fine.  r=me

We should be specifying accesskeys for check boxes and radio buttons now, so
that after bug 68841 is fixed we don't have to go through every dialog again to
add more accesskeys.
Attachment #115279 - Flags: review?(dean_tessman) → review+
(Assignee)

Updated

16 years ago
Attachment #115279 - Flags: superreview?(dmose)

Comment 5

16 years ago
Comment on attachment 115279 [details] [diff] [review]
Add accesskeys to bookmark props v2

Wouldn't it be better to use "D" for display an alert?

Comment 6

16 years ago
It's used for 'Description'.

Comment 7

16 years ago
Description is in a different tab.  Is it bad or not possible to reuse it in
that case?

Comment 8

16 years ago
Not currently, no.  See bug 143065.

Comment 9

16 years ago
Comment on attachment 115279 [details] [diff] [review]
Add accesskeys to bookmark props v2

Rather than living with inferior accesskeys, I think we should try and get bug
143065 fixed.
Attachment #115279 - Flags: superreview?(dmose) → superreview-
Marking as dependent on 143065.  If we get near the end of 1.4beta and this
still isn't done, then we can reconsider and perhaps land this patch.  But
getting 143065 fixed would be much preferable.
Depends on: 143065
(Assignee)

Comment 11

16 years ago
Dan, yeah, that would be ideal. But 143065 is nine months old with only 4 
comments - doesn't look too active :(

Comment 12

16 years ago
See Bug 117026 for a patched bm-props.xul, merging all tabs together.

Updated

16 years ago
QA Contact: kasumi → petersen

Updated

15 years ago
Depends on: 117026

Comment 13

15 years ago
alfred: you mention in bug 117026 that this bug should be fixed now, but i don't
see any access keys being bound to XUL elements in that patch.  i also couldn't
navigate the bookmarks properties dialog via access keys.  am i missing something?

Comment 14

15 years ago
Created attachment 132991 [details] [diff] [review]
Patch to add the accesskeys to the XUL

This patch addes the accesskeys to the XUL part.
Note, the accesskeys definitions are allready in bm-props.dtd
Note furthermore that bug 143065 is not relevant for this bug anymore,
as due to bug 117026 the tabpanels are now removed.

Updated

15 years ago
Attachment #115279 - Attachment is obsolete: true

Updated

15 years ago
Attachment #132991 - Flags: review?(darin)

Comment 15

15 years ago
Comment on attachment 132991 [details] [diff] [review]
Patch to add the accesskeys to the XUL

looks ok to me, but note: you should get module owner review as well.
Attachment #132991 - Flags: review?(darin) → review+

Updated

15 years ago
Attachment #132991 - Flags: superreview?(jag)

Updated

15 years ago
Flags: blocking1.6a?

Updated

15 years ago
Flags: blocking1.6a? → blocking1.6a-

Updated

15 years ago
Attachment #132991 - Flags: superreview?(jag) → superreview?(neil.parkwaycc.co.uk)

Comment 16

15 years ago
Did you mean to get darin's sr and my r?

Comment 17

15 years ago
Comment on attachment 132991 [details] [diff] [review]
Patch to add the accesskeys to the XUL

>@@ -84,7 +88,7 @@
>         </columns>
>         <rows>
>           <row align="center">
>-            <label value="&when.label;" control="dayRange"/>
>+            <label value="&when.label;"  accesskey="&when.accesskey;" control="dayRange"/>

Extra space here.

sr=jag

Maybe if someone's bored they could change "duration" to "interval" in some
other bug.
Attachment #132991 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview+

Comment 18

15 years ago
Created attachment 138103 [details] [diff] [review]
Fixed the space
Attachment #132991 - Attachment is obsolete: true

Comment 19

15 years ago
fixed on trunk for 1.7 alpha
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.