1945582 - [wpt-sync] Sync PR 50448 - [SVG] Fix viewport calculation for uninstanced symbol elements.

Status: RESOLVED FIXED

(Core :: SVG, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50448 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50448
Details from upstream follow.

Divyansh Mangal <[e-mail]> wrote:

[SVG] Fix viewport calculation for uninstanced symbol elements.

The test svg-baseval-in-display-none.html verifies the behavior of
the baseVal property for SVG elements, including the symbol
element. It ensures that the baseVal properties of geometry
elements inside the symbol element are correctly computed.

To compute the correct baseVal properties, the viewport size is
required when width and height are given in percentage format.
However, in Chromium, the symbol element (as a viewport element)
always returns an empty viewport size when computing baseVal
properties. This results in the baseVal properties returning zero
values.

The spec[1] says either the svg element or a symbol element
that is instanced by a use element establishes a new viewport.
In the test, the symbol isn't instanced, so the expectation should
be that the nearest ancestor svg provides the viewport.
In this CL, we compute the viewport size for the symbol element
provided by its nearest svg ancestor.

[1] https://svgwg.org/svg2-draft/coords.html#EstablishingANewSVGViewport

Bug: 41463219,41461114
Change-Id: Iac60cb45f1284db78c36a60c54e9dd9c341172ee

Reviewed-on: https://chromium-review.googlesource.com/6217852
WPT-Export-Revision: db832c14138167af0602160969249e75853b8bbd

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b7b69cf202fbe992d2ffcf11831d636ea160e4d8

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

OK : 1
PASS: 1
FAIL: 1

Chrome

OK : 1
PASS: 1
FAIL: 1

Safari

OK : 1
PASS: 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /svg/geometry/svg-baseval-in-display-none.html [wpt.fyi]
  • With em and percentage: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15d2d8306e40
[wpt PR 50448] - [SVG] Fix viewport calculation for uninstanced symbol elements., a=testonly
https://hg.mozilla.org/integration/autoland/rev/6ec15f684015
[wpt PR 50448] - Update wpt metadata, a=testonly

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/15d2d8306e40
https://hg.mozilla.org/mozilla-central/rev/6ec15f684015