1946844 - Fix viewport calculation for uninstanced symbol elements

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Robert Longson [:longsonr]]

SVG 2 clarified that only symbols that are instanced by use elements count as viewports

Comment 1

[Robert Longson [:longsonr]]

Attachment: Bug 1946844 - Fix viewport calculation for uninstanced symbol elements r=emilio

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90f0b0004226
Fix viewport calculation for uninstanced symbol elements r=emilio

Comment 3

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=69f7afab248a7e13cb3d4febc9033374c1d25638

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/90f0b0004226

Comment 5

[Alex Finder]

(In reply to Pulsebot from comment #2)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90f0b0004226
Fix viewport calculation for uninstanced symbol elements r=emilio

Perfherder has detected a mozperftest performance change from push 90f0b0004226da5025acc6f9b45d2d2371bf71cb.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
4%	browser_ml_autofill_perf.js AUTOFILL-model-run-latency	linux1804-64-shippable		18.77 -> 18.04
3%	browser_ml_summarizer_perf.js SUM-XENOVA-DISTILBART-CNN-12-6_BIG-initialization-latency	linux1804-64-shippable		2,769.94 -> 2,687.71
3%	browser_ml_summarizer_perf.js SUM-XENOVA-DISTILBART-CNN-12-6_BIG-pipeline-ready-latency	linux1804-64-shippable		2,753.02 -> 2,672.17
3%	browser_ml_summarizer_perf.js SUM-XENOVA-DISTILBART-CNN-12-6_SMALL-initialization-latency	linux1804-64-shippable		2,774.90 -> 2,693.88
3%	browser_ml_summarizer_perf.js SUM-XENOVA-DISTILBART-CNN-12-6_SMALL-pipeline-ready-latency	linux1804-64-shippable		2,757.85 -> 2,677.79

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 43796

For more information on performance sheriffing please see our FAQ.

Comment 6

[Robert Longson [:longsonr]]

This performance change is incredibly unlikely to be correct as I suspect none of these tests have any SVG at all in them.