Closed Bug 1945758 Opened 1 year ago Closed 9 months ago

Add a page to Lando that shows the state of a job, with links to relevant systems

Categories

(Conduit :: Lando, enhancement, P3)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emilio, Assigned: shtrom)

References

(Depends on 1 open bug, Blocks 4 open bugs)

Details

(Keywords: leave-open)

Attachments

(7 files)

mach try is super fast now thanks to lando (thanks!)

However one of the things I commonly miss from --push-to-vcs is the ability of copying a link from the terminal output into the bug / phab revision. This is specially useful if I'm pushing to try on behalf of other people.

Since the push takes a variable amount of time to show up in treeherder, it's easy to forget to go back there and get the right link.

It'd be nice if lando jobs had a URL that, once landed, linked / redirected to treeherder, so that I could just post that.

Seems lando has both the rev and the tree so I think it should be workable.

Type: defect → enhancement

We have discussed this within the team several times, it is definitely on our radar. We need to find time to prioritize the work but it is coming soon. :)

Priority: -- → P3
See Also: → 1652787
Duplicate of this bug: 1952894
See Also: → 1965152
Duplicate of this bug: 1965152
Severity: -- → S2
Summary: Consider having some sort of linkable lando job URL → Store the treeherder linked generated when pushing to try, and expose it via the API and UI
Severity: S2 → S3
Summary: Store the treeherder linked generated when pushing to try, and expose it via the API and UI → Add a page to Lando that shows the state of a landing job, with links to relevant systems (eg. a link to treeherder for a try push)
See Also: → 1964784
See Also: → 1965979
Summary: Add a page to Lando that shows the state of a landing job, with links to relevant systems (eg. a link to treeherder for a try push) → Add a page to Lando that shows the state of a job, with links to relevant systems (eg. a link to treeherder for a try push)
Duplicate of this bug: 1965976
No longer duplicate of this bug: 1965976
Duplicate of this bug: 1965979
Blocks: 1965995
See Also: 1965152, 1965979
Assignee: nobody → omehani
No longer duplicate of this bug: 1965152
No longer duplicate of this bug: 1952894
Depends on: 1965976
Status: NEW → ASSIGNED

:emilio

I see that mach try now does show both job status and TreeHerder links (added with bug 1964784)

Lando try submission success, took 1.3 seconds. Landing job id: 136624.
Lando Job Status API: https://api.lando.services.mozilla.com/landing_jobs/136624
Follow the progress of your build on Treeherder: https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=136624

I assume that's the same summary information you'd like to have available at a lando-based URL (also to be show by mach try).

Is there any other info that you think would be useful to include on that page, too?

Flags: needinfo?(emilio)
Attachment #9494242 - Attachment description: [mozilla-conduit/lando] ui: add legacy_ui view (bug 1945758) (#364) → [mozilla-conduit/lando] ui: add legacy_try view (bug 1945758) (#364)

Here's a WIP of the status page. Now is a good time to say what you'd like in it (:

In comment 0 I was mostly concerned about the treeherder link tbh, but that page looks good :)

Flags: needinfo?(emilio)

Some internal discussion led to those suggestions:

  • covering all jobs (not just Try)
  • commit should link to the repo
  • not sure what the value is in linking to the json; everything there should be present on this page
  • there should be a link to the bug and phab revision (if present)
  • there should be a link to /D{id}
  • url like/D{id}/job or /D{id}/
  • queue for in-progress jobs
  • timestamps - submission and landed
  • error breakdown for the job

(In reply to Olivier Mehani [:shtrom] from comment #10)

Some internal discussion led to those suggestions:

  • covering all jobs (not just Try)

The page will only support jobs landed through lando.moz.tools, which excludes try. Any effort spent on supporting both old and new Landos is better spent on migrating off the old Lando.

Summary: Add a page to Lando that shows the state of a job, with links to relevant systems (eg. a link to treeherder for a try push) → Add a page to Lando that shows the state of a job, with links to relevant systems
Blocks: 1971930

Little prerequisite to resolve Hg SHAs from Git commit for TreeHerder links.

Authored by https://github.com/shtrom
https://github.com/mozilla-conduit/lando/commit/474ae33fb40aeeeacca84ca38f2c48e6cc195784
[main] utils: use raw query to pause workers for maintenance (bug 1945758) (#420)

Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Keywords: leave-open
Resolution: FIXED → ---

Authored by https://github.com/shtrom
https://github.com/mozilla-conduit/lando/commit/d3482ed351a2ffc581e27f8070285184633c5e68
[main] commit_map: move git2hg and hg2git logic from view into model (bug 1945758) (#415)

Blocks: 1977975

The code has landed for Landing Jobs. There is some support for API jobs, but the information is not as complete as for Landing Jobs just yet. This will be addressed, albeit with lower priority, in bug 1977975)

Try jobs are currently still on old Lando, and don't benefit from this just yet, but this will be addressed as part of bug 1965997)

Status: REOPENED → RESOLVED
Closed: 10 months ago9 months ago
Resolution: --- → FIXED
Regressions: 1981857
Duplicate of this bug: 1753265
Regressions: 2012499
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: