1964784 - Convert lando commit ID link output from mach try commands to a treeherder link

Status: RESOLVED FIXED

(Developer Infrastructure :: Try, enhancement)

Description

[Greg Mierzwinski [:sparky]]

This bug is for converting the existing line being output from mach try lando pushes to a treeherder link. It should use the landoCommitID (or whatever it ends up being called) parameter for this.

So instead of ouptutting Lando Job Status API: https://api.lando.services.mozilla.com/landing_jobs/130079
It should output something like Treeherder link: https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=130079

Comment 1

[:glob ✱]

This isn't possible from mach try, where this bug is filed - pushing to try is now asynchronous; mach is pushing the job into a queue and the try link isn't generated until after that job is processed, which might be some time later.

The slightly more recently filed bug 1964783 is closer to what is viable, duping to that one.

Comment 2

[Greg Mierzwinski [:sparky]]

Maybe my bug wasn't clear enough. We would do this within mach try by grabbing the lando commit ID that is output, and converting it into a treeherder link (after the dependency bug 1964783 is resolved). So it wouldn't be done on the lando side. Can you elaborate on what you were thinking? I think there might be a misunderstanding. The bug you closed this as a duplicate of seems to be related to something on the lando side instead of the mach try side.

Oh, are we not able to capture the lando commit ID line from the push output locally? It seems like it should be doable to me.

Comment 3

[:glob ✱]

:sparky and I had a quick chat that clarified the intended mach try perf workflow, which is:

1. mach try perf is run
2. along with the current link to Lando that mach try outputs, mach try perf will output a link to perf.compare
3. the perf.compare page polls Lando's public API; once the job lands it uses the try commit SHA

This bug is tracking the second step: mach try needs to hand the Lando commit-id over the mach try perf so it can take appropriate action.

Comment 4

[Greg Mierzwinski [:sparky]]

Attachment: Bug 1964784 - Return lando commit ID from lando push. r?ahal

Comment 5

[Greg Mierzwinski [:sparky]]

Attachment: Bug 1964784 - Output treeherder link with lando commit ID during push to try. r?#perftest,ahal

This patch an output of a treeherder link during the standard push to try, and during the mach try perf push to try.

Depends on D248644

Comment 6

[Greg Mierzwinski [:sparky]]

PR on treeherder has landed to add a landoCommitID URL parameter, and the changes have been deployed: https://github.com/mozilla/treeherder/pull/8692

See this link for an example: https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=131944

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/477c2ab787d2
Return lando commit ID from lando push. r=ahal
https://hg.mozilla.org/integration/autoland/rev/fad84c01cf0e
Output treeherder link with lando commit ID during push to try. r=ahal

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/477c2ab787d2
https://hg.mozilla.org/mozilla-central/rev/fad84c01cf0e

Comment 9

[Alastor Wu [:alwu]]

Today when I tried to push my patch via lando, I see the following message showing that landoCommitID=None, which seems a bug? Let me know if I should file a new bug.

$ ./mach try fuzzy --preset media-full
Using JujutsuRepository because a ".jj/" directory was detected!

Warning: jj support is currently experimental, and may be disabled by setting the
environment variable MOZ_AVOID_JJ_VCS=1. (This warning may be suppressed by
setting MOZ_AVOID_JJ_VCS=0.)
estimates: Runs 339 tasks (296 selected, 43 dependencies)
estimates: Total task duration 2 days, 1:38:39
estimates: In the longest 28% of durations
estimates: Should take about 1:52:53 (Finished around 2025-05-27 19:33)
Note: `--push-to-lando` is now the default behaviour of `mach try`.
Note: Use `--push-to-vcs` to push changes to try directly.
Auth0 token validated.
Working copy  (@) now at: yqzlwusq f02430ef (empty) Fuzzy query=mochitest-media !dfpi !nofis&query=mochitest-media android !spi !swr !lite&query=mochitest-browser-chrome !dfpi !nofis !a11y&query=mochitest-browser-media&query=web-platform-tests !dfpi !nofis !shippable&query=web-platform-tests android !wdspec !spi !swr !lite&query=crashtest !wdspec !nofis&query=crashtest android !wdspec !spi !swr !lite&query='gtest
Parent commit (@-)      : rlxtuttr 1a8b4d30 Bug 1967831 - part7 : make MediaChannelStatistics thread-safe.
Using 2cc2a23d363f585f5447d3c89b64b9b74617e980 as the git base commit.
Submitting stack of 7 nodes and the try commit.
Patches gathered for submission.
Submitting patches to Lando.
abort: error submitting patches to Lando.
The API is in maintenance, please try again later. landoapi_api_try_push_post_patches
Restored to operation: 420ea21a37c7 (2025-05-27 17:40:03) restore to operation bd9e0fa65bdaab674b34920d2521ed7c6e158cf2f477c6231d081c0cd37ae3bd6162abcf6bdcd8199469b02d4ab120523b3df274b1043665a7fc83ff417d5b14
Working copy  (@) now at: yqzmwtyk 848fd88a (empty) (no description set)
Parent commit (@-)      : rlxtuttr 1a8b4d30 Bug 1967831 - part7 : make MediaChannelStatistics thread-safe.
Added 0 files, modified 0 files, removed 1 files
Follow the progress of your build on Treeherder: https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=None

Comment 10

[Greg Mierzwinski [:sparky]]

:alwu, oh thanks for bringing this up - can you file a new bug for it, and CC me on it? We're not checking to see if the lando commit ID was actually produced (note the maintenance mode message) and producing the links anyway.