Closed Bug 1946357 Opened 7 months ago Closed 7 months ago

PMingLiU is incorrectly specified as the default sans-serif font for zh-TW

Categories

(Core :: Layout: Text and Fonts, defect)

Product:
Core
Component:
Layout: Text and Fonts
Version:
Firefox 135
Platform:
Desktop
Windows
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
137 Branch
Tracking Flags:
Tracking Status
firefox137 --- fixed

People

(Reporter: pan93412, Assigned: jfkthame, NeedInfo)

References

Details

Attachments

(5 files)

Firefox selects PMingLiu for the font family "sans-serif"
103.82 KB, image/png
Details
The behavior of all browsers (Edge, Firefox, and Chrome)
97.84 KB, image/jpeg
Details
The minimum reproducible web page
311 bytes, text/html
Details
6136263722356818971.jpg
53.98 KB, image/jpeg
Details
Bug 1946357 - Prefer Microsoft JhengHei as sans-serif font for zh-TW locale on Windows for all release channels. r=#layout
48 bytes, text/x-phabricator-request
Details | Review

Steps to reproduce:

Open the following page in Firefox on Windows:

<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <title>Document</title>

    <style>
        body {
            font-family: sans-serif;
        }
    </style>
</head>
<body>
    測試中文 ABCD
</body>
</html>

Actual results:

You will see Firefox select "PMingLiU" (which is a Serif font) for "sans-serif".

Expected results:

For any other browsers (Edge 133.0.3065.39 and Chrome 133.0.6943.54), the real sans-serif font "Microsoft JhengHei" is selected.

Component: Untriaged → General
OS: Unspecified → Windows
Hardware: Unspecified → Desktop

Note that Firefox selects the correct sans-serif font on Firefox Beta [1], and it should be

Version: Firefox 137 → Firefox 135

(In reply to Yi-Jyun Pan from comment #2)

Note that Firefox selects the correct sans-serif font on Firefox Beta 1, and it should be

Sorry for the incomplete comment; I submitted it accidentally.

Firefox selects the correct sans-serif font, Microsoft JhengHei, on Firefox Beta 1. It previously selected this font in the stable version until Issue 1517937 arose. Since Chromium has updated its sans-serif font to Microsoft JhengHei 2, I believe it is no longer necessary to choose PMingLiU for sans-serif.

Attachment #9464311 - Attachment description: The reproducible web page → The minimum reproducible web page

The Bugbug bot thinks this bug should belong to the 'Core::Layout: Text and Fonts' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: General → Layout: Text and Fonts
Product: Firefox → Core

(typo removed)

See Also: → 1517937, 88579

zh-TW locale owner here, some background information:

  1. In Bug 1394709 we added Microsoft JhengHei to the font fallback list.
  2. In Bug 1517937c3, some user complained about having MSJH before PMingLiu as a default, so we moved MSJH to the end of preference list for Release, and keep it first (as zh-TW default font) in Beta and Nightly.
  3. Chrome and Edge also had their default changed to MSJH in 2016 to use modern zh fonts [1].

After all these years, I believe it's time again to make it default for all channels.

[1] https://chromium.googlesource.com/chromium/src.git/+/5129404af72b720b8074a7277e088b001bd3c9e7%5E%21/#F1

(In reply to Peter Pin-Guang Chen [:petercpg] (MozTW.org) from comment #8)

zh-TW locale owner here, some background information:

  1. In Bug 1394709 we added Microsoft JhengHei to the font fallback list.
  2. In Bug 1517937c3, some user complained about having MSJH before PMingLiu as a default, so we moved MSJH to the end of preference list for Release, and keep it first (as zh-TW default font) in Beta and Nightly.
  3. Chrome and Edge also had their default changed to MSJH in 2016 to use modern zh fonts [1].

After all these years, I believe it's time again to make it default for all channels.

I agree this is the right thing to do. (I suspect we may still get some pushback from people who dislike the change, but the current configuration doesn't really make sense.)

Severity: -- → S3

We've been shipping this configuration on Nightly/early-Beta since bug 1394709
(7 years ago), but temporarily reverted it for late-Beta/Release in bug 1517937
due to issues with the JhengHei font and some users' preference for the old
PMingLiu face.

But as reported in this bug, PMingLiu really isn't an appropriate mapping for
'sans-serif', and as :petercpg suggests in [1], it seems like time to ship
this change.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1946357#c8

Assignee: nobody → jfkthame
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

Also, the behavior difference between the release and beta confused people. Users who think this is a bug easily believe that it will be fixed in the next release.

Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5738d17b06cd Prefer Microsoft JhengHei as sans-serif font for zh-TW locale on Windows for all release channels. r=dshin,TYLin

https://hg.mozilla.org/mozilla-central/rev/5738d17b06cd

Status: ASSIGNED → RESOLVED
Closed: 7 months ago
status-firefox137: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch

I tried to reproduce the issue on a Firefox Nightly 137.0a1(2025-02-06) on a zh-TW locale on both Windows 10/ Windows 11 with no success.
Given the case, can you please confirm that the issue is fixed on the latest Firefox 137 beta build? Thank you.

Flags: needinfo?(pan93412)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: