1394709 - Add Microsoft JhengHei to font.name-list.sans-serif.zh-TW

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, enhancement, P3)

Description

[Makoto Kato [:m_kato]]

http://searchfox.org/mozilla-central/rev/cd82cacec2cf734768827ff85ba2dba90a534c5e/modules/libpref/init/all.js#3721

We don't have Microsoft JhengHei entry in zh-TW of sans-serif.  Since we should add this to this entry.  Since Microsoft JhengHei is one of default font of zh-TW.

Comment 1

[Makoto Kato [:m_kato]]

Tim, I would like to get feedback this changes from TPE team.  Who is best person?

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Loop the localization/local community should be sufficient.

PS what do you think about bug 1350766? Do you think we'll need to some feedback too?

Comment 3

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

The reason we did not put Microsoft Jhenghei into font.name-list.*.zh-TW is there are known bugs like redundant spaces after some characters, and overlapping issues when rotated. [1] [2]

However, I still support this change.


[1] https://support.microsoft.com/zh-tw/help/2710845, 'Microsoft suggested not to use MSJH to display Chinese temporarily'
[2] https://zh.wikipedia.org/wiki/%E5%BE%AE%E8%BB%9F%E6%AD%A3%E9%BB%91%E9%AB%94

Comment 4

[Makoto Kato [:m_kato]]

(In reply to Peter Pin-Guang Chen [:petercpg] (MozTW.org) from comment #3)
> The reason we did not put Microsoft Jhenghei into font.name-list.*.zh-TW is
> there are known bugs like redundant spaces after some characters, and
> overlapping issues when rotated. [1] [2]
> 
> However, I still support this change.
> 
> 
> [1] https://support.microsoft.com/zh-tw/help/2710845, 'Microsoft suggested
> not to use MSJH to display Chinese temporarily'
> [2]
> https://zh.wikipedia.org/wiki/%E5%BE%AE%E8%BB%9F%E6%AD%A3%E9%BB%91%E9%AB%94

I see.  But Chrome and Edge seem to change to Microsoft Jhenghei as default font with this bug.

Comment 5

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

(In reply to Makoto Kato [:m_kato] from comment #4)
> (In reply to Peter Pin-Guang Chen [:petercpg] (MozTW.org) from comment #3)
> > The reason we did not put Microsoft Jhenghei into font.name-list.*.zh-TW is
> > there are known bugs like redundant spaces after some characters, and
> > overlapping issues when rotated. [1] [2]
> > 
> > However, I still support this change.
> > 
> > 
> > [1] https://support.microsoft.com/zh-tw/help/2710845, 'Microsoft suggested
> > not to use MSJH to display Chinese temporarily'
> > [2]
> > https://zh.wikipedia.org/wiki/%E5%BE%AE%E8%BB%9F%E6%AD%A3%E9%BB%91%E9%AB%94
> 
> I see.  But Chrome and Edge seem to change to Microsoft Jhenghei as default
> font with this bug.

Yep, bugs are reproducible on Fx/GC/Edge on my Win 10 PC so I'm good with this. Thank you Kato-san.

Comment 6

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=527c2891c0d77d3836f889fd4f922aae28ffa890

Comment 7

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=985dc7d39eadc155441d42c255d2f138fba3cc06

Comment 8

[Makoto Kato [:m_kato]]

Attachment: Add Microsoft JhengHei to font.name-list.sans-serif.zh-TW for Nightly

Comment 9

[Krasnaya Ploshchad’]

Is it possible to merge the above patch?

Comment 10

[Makoto Kato [:m_kato]]

(In reply to Krasnaya Ploshchad’ from comment #9)
> Is it possible to merge the above patch?

Yes, https://treeherder.mozilla.org/#/jobs?repo=try&author=[e-mail] seems to be passed.

Comment 11

[Makoto Kato [:m_kato]]

Comment on attachment 8952957 [details] [diff] [review]
Add Microsoft JhengHei to font.name-list.sans-serif.zh-TW for Nightly

Default Traditional Chinese font of Chrome and Edge on Windows are Microsoft JhengHei now, so we should change it to same font that supports ClearType.

Also, this font has a bug (see comment #3 and comment #4), but Edge and Chrome are same result for this.

Comment 12

[Jonathan Kew [:jfkthame]]

With the current patch restricting it to Nightly/Early-Beta only, we'll presumably want a followup to let it ride the release train fairly soon, unless unexpected problems (beyond the already-known bugs) show up.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a3947599d1af
Add Microsoft JhengHei to font.name-list.sans-serif.zh-TW. r=jfkthame

Comment 14

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/a3947599d1af