1946398 - Message compose window closes unexpectedly when sending a news message fails.

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Hartmut Welpmann [:welpy-cw]]

Steps to reproduce:

1. Select an NNTP server in the folder pane and compose a new message with some subject and content.
2. Specify a newsgroup the server does not provide.
3. Send the message.

Expected result:
An alert window saying "A News (NNTP) error occurred: No valid newsgroups in …" appears. After you confirm the error, the compose window should still be displayed so that you can modify the message.

Actual result:
The alert window is displayed, but the compose window is closed after confirming.

Comment 1

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1946398 - Fix regression for news messages from Bug 1922821. r=#thunderbird-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4c603d410493
Fix regression for news messages from Bug 1922821. r=mkmelin

Comment 3

[Corey Bryant]

@hartmut How do you feel about uplifting this to 136 beta? It is very late in the cycle but considering this fixes a regression perhaps it is low risk and worth it?

Comment 4

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9464341 [details]
Bug 1946398 - Fix regression for news messages from Bug 1922821. r=#thunderbird-reviewers

[User impact if declined]

• If sending a news message fails, for example, because the server doesn't provide the specified newsgroup, the message compose window closes unexpectedly, and all message data the user has entered is lost.

[Is this code covered by automated tests?]

• Options: No.

[Has the fix been verified in Daily? (or Beta for an ESR uplift?)]

• Verified by myself and reviewer in Daily.

[Needs manual test from QA?]

• Yes.
• Follow the STR provided in the description of the bug.

[Risk to taking this patch]

• Options: Very low.

[Why is the change risky/not risky? (and alternatives if risky)]

• This simply corrects a refactoring oversight without actually changing the code flow.

[String changes made/needed]

• None.

Comment 5

[Corey Bryant]

Hartmut, sorry this didn't get included in the recent uplifts to 136.0. We'll pick it up in the next beta merge on Monday and perhaps we can uplift to 136.0.1 for the release channel?

Comment 6

[Corey Bryant]

Comment on attachment 9464341 [details]
Bug 1946398 - Fix regression for news messages from Bug 1922821. r=#thunderbird-reviewers

[Triage Comment]
This will be picked up in next Monday's merge of cc->beta

Comment 7

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9464341 [details]
Bug 1946398 - Fix regression for news messages from Bug 1922821. r=#thunderbird-reviewers

[User impact if declined]

• If sending a news message fails, for example, because the server doesn't provide the specified newsgroup, the message compose window closes unexpectedly, and all message data the user has entered is lost.

[Is this code covered by automated tests?]

• Options: No.

[Has the fix been verified in Daily? (or Beta for an ESR uplift?)]

• Verified by myself and reviewer in Daily.

[Needs manual test from QA?]

• Yes.
• Follow the STR provided in the description of the bug.

[Risk to taking this patch]

• Options: Very low.

[Why is the change risky/not risky? (and alternatives if risky)]

• This simply corrects a refactoring oversight without actually changing the code flow.

[String changes made/needed]

• None.

Comment 8

[Corey Bryant]

Comment on attachment 9464341 [details]
Bug 1946398 - Fix regression for news messages from Bug 1922821. r=#thunderbird-reviewers

[Triage Comment]
Approved for release

Comment 9

[Daniel Darnell [:dandarnell]]

Thunderbird 136.0.1:
https://hg.mozilla.org/releases/comm-release/rev/b35f5f29d171