Closed Bug 1946400 Opened 1 year ago Closed 1 year ago

Move nsBrowserAccess (nsIBrowserDOMWindow implementation on desktop) to its own module

Categories

(Firefox :: General, task)

Product:
Firefox
Component:
General
Platform:
Desktop
All
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
137 Branch
Tracking Flags:
Tracking Status
firefox137 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

Bug 1946400 - move nsBrowserAccess (nsIBrowserDOMWindow impl) out of browser.js into its own module, r?#firefox-desktop-core-reviewers
48 bytes, text/x-phabricator-request
Details | Review
Bug 1946400 - bonus: move some other DCL/unload handling in browser-init.js to use the category manager, r?#firefox-desktop-core-reviewers
48 bytes, text/x-phabricator-request
Details | Review

I was looking at browser.js again and got annoyed and decided to just pick up a shovel.

Blocks: 1948931

Comment on attachment 9466719 [details]
Bug 1946400 - move toolbar window initialization into CustomizableUI, r?mconley

Revision D238536 was moved to bug 1948931. Setting attachment 9466719 [details] to obsolete.

Attachment #9466719 - Attachment is obsolete: true
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/88961496629c move nsBrowserAccess (nsIBrowserDOMWindow impl) out of browser.js into its own module, r=firefox-desktop-core-reviewers ,mossop https://hg.mozilla.org/integration/autoland/rev/df8e24e9be67 bonus: move some other DCL/unload handling in browser-init.js to use the category manager, r=firefox-desktop-core-reviewers ,mossop

Backed out for causing conflicts with backing out Bug 1916424 : https://hg.mozilla.org/integration/autoland/rev/06e2b37c4ceb05950f72581d6769c66d44352122

Flags: needinfo?(gijskruitbosch+bugs)
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/6083c93aa77a move nsBrowserAccess (nsIBrowserDOMWindow impl) out of browser.js into its own module, r=firefox-desktop-core-reviewers ,mossop https://hg.mozilla.org/integration/autoland/rev/9365f974a47b bonus: move some other DCL/unload handling in browser-init.js to use the category manager, r=firefox-desktop-core-reviewers ,mossop

https://hg.mozilla.org/mozilla-central/rev/6083c93aa77a
https://hg.mozilla.org/mozilla-central/rev/9365f974a47b

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox137: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch
Flags: needinfo?(gijskruitbosch+bugs)
See Also: → 1950375
See Also: → 1952900
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: