1947023 - Test-case reducer add-on is blank on Nightly

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

STR

1. Install https://addons.mozilla.org/en-US/firefox/addon/testcase-reducer/
2. Go to any site like wikipedia.
3. Inspect a node.
4. Click on the test-case reducer add-on.

What happened?

Blank panel.

What should have happened?

The extension panel shows up.

Bisected to https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=248076e70562bfc598d78c68fc1266df0bdc03cb&tochange=0650029a3ec3ced370663cd51701c62a77383337

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1943543

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Might be a Core issue since switching the deck to display: none and back "fixes" the issue...

Comment 3

[Emilio Cobos Álvarez (:emilio)]

I think this is wrong: It only propagates to same-browsing-context-tree children, but not to top descendants...

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1947023 - Propagate hidden-under-embedder properly to nested tops. r=nika,farre

Comment 5

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Bug 1947023 - [devtools] Fix showing Web extension panels in DevTools.

Toggling its visibility before loading the inner html document workaround
the platform issue around "IsUnderHiddenEmbedderElement".

Comment 6

[Alexandre Poirot [:ochameau] [PTO back August 21]]

I'm also attaching a really simple workaround in devtools, which simply reverts a small change I did in the regressor.
Just in case we can't get the BrowsingContext fix landed shortly.

Comment 7

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Thanks emilio for jumping on fixing the BrowsingContext code. I pushed the devtools workaround to fix webextension addons in the next nightly.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4d063601888
[devtools] Fix showing Web extension panels in DevTools. r=devtools-reviewers,nchevobbe

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88f8b983d30d
Propagate hidden-under-embedder properly to nested tops. r=nika,devtools-reviewers,ochameau

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b4d063601888
https://hg.mozilla.org/mozilla-central/rev/88f8b983d30d

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Do you want to remove the DevTools workaround?

Comment 12

[Alexandre Poirot [:ochameau] [PTO back August 21]]

yes, I'll do that.