1947355 - Prepare Suggest UI strings for localization

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P2)

Description

[Drew Willcoxon :adw]

With Suggest experimentally expanding to other locales, we'll need to move all the Suggest l10n strings out of enUS-searchFeatures.ftl and into proper l10n files so they can be localized. I don't believe we'll need to update any code except for possibly importing the proper ftl file(s) in the appropriate places if they're not already.

There are only a handful of locales we know we need to support right now, so it would be nice to check with flod about whether we can limit localization to those locales so that l10n contributors for other locales don't have to do any work.

Comment 1

[Drew Willcoxon :adw]

(In reply to Drew Willcoxon :adw from comment #0)

There are only a handful of locales we know we need to support right now, so it would be nice to check with flod about whether we can limit localization to those locales so that l10n contributors for other locales don't have to do any work.

I checked with flod and that's not possible, it's all or nothing: https://mozilla-l10n.github.io/documentation/products/firefox_desktop/firefox_l10n_faqs.html#can-i-get-content-translated-only-in-selected-languages

Comment 2

[Drew Willcoxon :adw]

Attachment: Bug 1947355 - Prepare Suggest AMP and Wikipedia strings for localization.

This moves l10n strings related to AMP and Wikipedia suggestions out of
enUS-searchFeatures.ftl into the appropriate l10n files in preparation for AMP
and Wikipedia in non-U.S. regions. These strings include:

• The result menu item strings, Dismiss and Manage
• Relevant settings UI strings

urlbar-result-menu-learn-more-about-firefox-suggest isn't actually used by AMP
and Wikipedia right now, but it was in the past, and there have been recent
discussions about maybe including it again as Suggest expands outside the U.S.
So I moved it too in case we need it with short notice.

There are other Suggest strings that this patch does not move, in particular:

• -firefox-suggest-brand-name is already exposed to localizers
• The "Sponsored" label at the bottom of AMP urlbar rows is already exposed to
  localizers as urlbar-result-action-sponsored
• Strings for the online toggle switch in the settings UI ("Improve the Firefox
  Suggest experience") aren't needed right now because online Suggest (Merino)
  won't be available outside the U.S. in the near future.

I changed the ID of the Dismiss string so it doesn't include "firefox-suggest".
Several non-Suggest urlbar results use this string too, and it doesn't actually
include the phrase "Firefox Suggest" anyway.

I also made the view default to this string so that dismissable urlbar results
don't need to specify it, similar to how it defaults to strings for "Learn more"
and Manage.

Depends on D238847

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6f09e675454
Prepare Suggest AMP and Wikipedia strings for localization. r=daisuke,fluent-reviewers,urlbar-reviewers,bolsson

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c6f09e675454