1948019 - "Forget About This Site" context menu option missing from Firefox View history

Status: RESOLVED FIXED

(Firefox :: Firefox View, defect, P2)

Description

[Kestrel]

Attachment: Comparison of history context menus between Firefox View and old sidebar

STR:

1. Visit about:firefoxview#history.
2. Click the ellipses "..." for a page.

Expected:
"Forget About This Site" menu item appears like with history in Hamburger menu, Library (Ctrl+Shift+O) and old sidebar.

Actual:
Only "Delete from history" is available which clears individual pages but not entire sites.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:sfoster, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Nikki Sharpley (:nikkis) (she/her)]

The new sidebar history panel has this functionality included here: https://searchfox.org/firefox-main/rev/7b1a35d6c70c08d2966c6c8dfc9aa9c04319f721/browser/components/sidebar/sidebar-page.mjs#171-188
We should add a new context menu option here with this functionality: https://searchfox.org/firefox-main/rev/7b1a35d6c70c08d2966c6c8dfc9aa9c04319f721/browser/components/firefoxview/history.mjs#241-267

Comment 3

[Nikki Sharpley (:nikkis) (she/her)]

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help.
   This will tell others that you're working on the next steps.
2. Download and build the Firefox source code
   • If you have any problems, please ask on
     Element/Matrix
     in the #introduction channel. They're there to help you get started.
   • You can also read the
     Firefox Contributors' Quick Reference,
     which has answers to most development questions.
3. Start working on this bug.
   • If you have any problems with this bug,
     please comment on this bug and set the needinfo flag for me.
     Also, you can find me and my teammates on the #sidebar channel on
     Element/Matrix
     most hours of most days.
4. Build your change with mach build and test your change with
   mach test browser/components/firefoxview/tests/browser.
   Also check your changes for adherence to our style guidelines by using mach lint
5. Submit the patch (including an automated test, if applicable) for review.
   Mark me as a reviewer so I'll get an email to come look at your code.
   • Getting your code reviewed
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch,
   I'll mark it for checkin or push it to autoland.
   Your code will soon be shipping to Firefox users worldwide!
7. ...now you get to think about what kind of bug you'd like to work on next.
   Let me know what you're interested in and I can help you find your next contribution.

Comment 4

[Chukwuka Rosemary]

Hi! I'm Rosemary Chukwuka, an Outreachy applicant. I'd like to work on this bug. Could you please assign it to me? I'm excited to contribute to Firefox

Comment 5

[Chukwuka Rosemary]

Hi! I'm Rosemary Chukwuka, an Outreachy applicant. I have submitted a patch for this bug to Phabricator:
https://phabricator.services.mozilla.com/D289065
Changes made:

Added forgetAboutThisSite() method to history.mjs
Added new panel-item to the context menu in panelListTemplate()

Please let me know if any changes are needed. Thank you!

Comment 6

[Chukwuka Rosemary]

Attachment: Bug 1948019 - Add Forget About This Site option to Firefox View history context menu

Added "Forget About This Site" context menu option to Firefox View
history (history.mjs).

Changes:

• Added forgetAboutThisSite() method to HistoryInView class
• Added new panel-item to panelListTemplate() context menu

This mirrors the existing functionality in sidebar-page.mjs
(lines 171-188) as suggested in the bug comments.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/538fb948475a
https://hg.mozilla.org/integration/autoland/rev/32727430f793
Add Forget About This Site option to Firefox View history context menu r=nsharpley,fxview-reviewers,fluent-reviewers,bolsson

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5728b324b0d6
https://hg.mozilla.org/integration/autoland/rev/b77a2ae11470
Revert "Bug 1948019 - Add Forget About This Site option to Firefox View history context menu r=nsharpley,fxview-reviewers,fluent-reviewers,bolsson" for causing bc failures @ browser_firefoxview_general_telemetry

Comment 9

[amarc]

Backed out for causing bc failures

• Backout link
• Push with failures
• Failure Log

Comment 10

[Chukwuka Rosemary]

Hi! Thank you for letting me know. I'm looking into the test failures and will work on a fix. Could you point me to what exactly failed so I can address it?
Best regards,
Rosemary Chukwuka

Comment 11

[Kelly Cochrane [:kcochrane]]

NIing Nikki so she's aware of the backout and may assist

Comment 12

[Chukwuka Rosemary]

Hi Kelly and Nikki! I've identified and fixed the issue. The forgetAboutThisSite function was missing the recordContextMenuTelemetry("forget-about-this-site", e) call, and there was no corresponding telemetry test. I've added both fixes and resubmitted D289065. Please let me know if any further changes are needed!
Best regards, Rosemary Chukwuka

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ba58adebac84
https://hg.mozilla.org/integration/autoland/rev/2701ae150a9b
Add Forget About This Site option to Firefox View history context menu r=nsharpley,fxview-reviewers,fluent-reviewers,bolsson

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a697e0a43116
https://hg.mozilla.org/integration/autoland/rev/54dbf39ec410
Revert "Bug 1948019 - Add Forget About This Site option to Firefox View history context menu r=nsharpley,fxview-reviewers,fluent-reviewers,bolsson" for causing lint failures @firefoxview/history.mjs.

Comment 15

[agoloman]

Backed out for causing lint failures @firefoxview/history.mjs.

• Backout link
• Push with failures
• Failure Log

Comment 16

[Chukwuka Rosemary]

Hi! I saw the lint failure in history.mjs and I'm working on fixing it right now. Will resubmit shortly!
Best regards,
Rosemary Chukwuka

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/34e5a96fc388
https://hg.mozilla.org/integration/autoland/rev/c0c69134db50
Add Forget About This Site option to Firefox View history context menu r=nsharpley,fxview-reviewers,fluent-reviewers,bolsson

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/47f1a1c3db8d
https://hg.mozilla.org/integration/autoland/rev/b605dca7757a
Revert "Bug 1948019 - Add Forget About This Site option to Firefox View history context menu r=nsharpley,fxview-reviewers,fluent-reviewers,bolsson" for causing bc failures @browser_firefoxview_general_telemetry.js.

Comment 19

[agoloman]

Backed out for causing bc failures @browser_firefoxview_general_telemetry.js.

• Backout link
• Push with failures
• Failure Log

Comment 20

[Chukwuka Rosemary]

Hi! I saw the backout. I'm looking into the telemetry test failure and will work on a fix. Could you share what exactly is failing in browser_firefoxview_general_telemetry.js?
Best regards, Rosemary Chukwuka

Comment 21

[Chukwuka Rosemary]

Hi! I have fixed the browser_firefoxview_general_telemetry.js timeout by removing the duplicate context menu button click. Resubmitted D289065. Please let me know if any further changes are needed!
Best regards,
Rosemary

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ada5be2eb911
https://hg.mozilla.org/integration/autoland/rev/7fda6c002440
Add Forget About This Site option to Firefox View history context menu r=nsharpley,fxview-reviewers,fluent-reviewers,bolsson

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/20516195b781
https://hg.mozilla.org/integration/autoland/rev/6857ba66dd5f
Revert "Bug 1948019 - Add Forget About This Site option to Firefox View history context menu r=nsharpley,fxview-reviewers,fluent-reviewers,bolsson" for causing bc failures @browser_firefoxview_general_telemetry.js.

Comment 24

[agoloman]

Backed out for causing bc failures @browser_firefoxview_general_telemetry.js.

• Backout link
• Push with failures
• Failure Log

Comment 25

[Chukwuka Rosemary]

Hi Nikki! I found the root cause of the test failure. Adding "Forget About This Site" as a new menu item shifted the indexes of all existing panel items. I have updated the tests:
openInNewWindowOption: panelItems[1] → panelItems[2]
openInPrivateWindowOption: panelItems[2] → panelItems[3]
Please let me know if any further changes are needed!
Best regards,
Rosemary Chukwuka

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/046c4068dc46
https://hg.mozilla.org/integration/autoland/rev/4cab04730758
Add Forget About This Site option to Firefox View history context menu r=nsharpley,fxview-reviewers,fluent-reviewers,bolsson

Comment 27

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/4cab04730758