2028153 - Add test for Forget This Site option in Fxview history context menu.

Status: RESOLVED FIXED

(Firefox :: Firefox View, enhancement)

Description

[Nikki Sharpley (:nikkis) (she/her)]

Now that we've added Forget This Site to the context menu for Firefox View history items, we should add a test that checks the presence of this option and the functionality.

Comment 1

[Chukwuka Rosemary]

Hi Nikki! Thank you so much for assigning this bug to me! I'm excited to work on it and will reach out if I need guidance.
Best regards,
Rosemary Chukwuka

Comment 2

[Chukwuka Rosemary]

Attachment: Bug 2028153 - Add test for Forget About This Site option in Fxview history context menu

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e851584978c7
https://hg.mozilla.org/integration/autoland/rev/c285ad3f8c82
Add test for Forget About This Site option in Fxview history context menu r=fxview-reviewers,nsharpley,places-reviewers,mak

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a9ecf70f1f99
https://hg.mozilla.org/integration/autoland/rev/fb3cf6c22ffa
Revert "Bug 2028153 - Add test for Forget About This Site option in Fxview history context menu r=fxview-reviewers,nsharpley,places-reviewers,mak" for causing bc failures at browser_history_firefoxview.js

Comment 5

[Silaghi Andreea]

Backed out for causing mochitest failures at browser_history_firefoxview.js
Backout Link
Push with failures
Failure Log
Failure line TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/browser/browser_history_firefoxview.js | test_forget_about_this_site_option - Test timed out

Comment 6

[Chukwuka Rosemary]

Thank you for the backout information. I am aware of the failure and have already notified my mentor Nikki Sharpley on Phabricator (D291424). The test is timing out on promiseForgotten / page-removed notification, this is a known flakiness issue that Nikki investigated previously. I am waiting for Nikki's guidance on the fix and will reland as soon as possible.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/297ef8a16440
https://hg.mozilla.org/integration/autoland/rev/ed0a11538bb9
Add test for Forget About This Site option in Fxview history context menu r=fxview-reviewers,nsharpley,places-reviewers,mak

Comment 8

[rperta]

https://hg.mozilla.org/mozilla-central/rev/ed0a11538bb9