1948141 - Run the stylelint-plugin-mozilla tests on automation

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Hanna Jones [:hjones]]

Once we've added some tests for our custom stylelint rules in 1921095 it would be ideal to get them running on automation. I expect we'll need a custom reporter along the lines of what was implemented for the eslint tests, though the stylelint tests will be backed by Node test runner instead of mocha. Some info on implementing custom reporters for Node tests can be found here.

I also expect a lot of the task configuration for eslint will be relevant to stylelint. :standard8 do you have any thoughts/pointers on how best to go about this? It looks like you did the initial work for running eslint tests in bug 1379119 and has evolved a bit since.

Comment 1

[Mark Banner (:standard8)]

(In reply to Hanna Jones [:hjones] from comment #0)

Once we've added some tests for our custom stylelint rules in 1921095 it would be ideal to get them running on automation. I expect we'll need a custom reporter along the lines of what was implemented for the eslint tests, though the stylelint tests will be backed by Node test runner instead of mocha.

Yes, the important parts are the TEST-UNEXPECTED-FAIL, TEST-PASS etc, they're the lines that treeherder & code review log parses detect.

I also expect a lot of the task configuration for eslint will be relevant to stylelint. :standard8 do you have any thoughts/pointers on how best to go about this? It looks like you did the initial work for running eslint tests in bug 1379119 and has evolved a bit since.

Thankfully it got a lot simpler recently.

Comment 2

[Mark Banner (:standard8)]

(In reply to Mark Banner (:standard8) from comment #1)

(In reply to Hanna Jones [:hjones] from comment #0)

I also expect a lot of the task configuration for eslint will be relevant to stylelint. :standard8 do you have any thoughts/pointers on how best to go about this? It looks like you did the initial work for running eslint tests in bug 1379119 and has evolved a bit since.

Thankfully it got a lot simpler recently.

[pressed return too early]

I think you'll need to duplicate this toolchain, and the associated script. Then you'll also need to duplicate the task configuration as you linked to.

Comment 3

[Hanna Jones [:hjones]]

Attachment: Bug 1948141 - run the stylelint-plugin-mozilla tests in automation r=#frontend-codestyle-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94b4f441e038
run the stylelint-plugin-mozilla tests in automation r=frontend-codestyle-reviewers,Gijs,Standard8,releng-reviewers,ahal

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/94b4f441e038