1948315 - add support for performing treescript operations through lando

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, enhancement)

Description

[[e-mail] (:bhearsum)]

hg.mozilla.org repositories are moving to github. On April 28th, writes to most repositories will stop working through hg.mozilla.org, and all changes will need to go through Lando. Our treescript scriptworkers, which deal with tagging, l10n bumps, and version bumps, will cease to function for Gecko operations at this point. Instead, we'll need to submit requests to Lando to accomplish these tasks (exact API is still TBD).

To deal with this, we will create new lando scriptworkers to do this. (Technically, we could do this in treescript, but we'd like to get rid of it after this is done, and we move the remaining things it does to githubscript, and it's a convenient time to get a fresh start...)

Comment 1

[[e-mail] (:bhearsum)]

Attachment: relengworker: add landoscript dev deployment

Comment 2

[[e-mail] (:bhearsum)]

Attachment: feat: add landoscript for gecko to nonprod

Comment 3

[[e-mail] (:bhearsum)]

Attachment: scriptworker-scripts: add lando

Comment 4

[[e-mail] (:bhearsum)]

Attachment: WIP: Bug 1948315: frame out landoscript changes

Comment 5

[[e-mail] (:bhearsum)]

The initial work here landed in https://github.com/mozilla-releng/scriptworker-scripts/pull/1135; there's been much follow-up work since, and more is still needed.

Comment 6

[BMO Github Automation]

Attachment: [mozilla-releng/fxci-config] bug 1948315: grant scopes for landoscript repos & actions (#352)

Comment 7

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: add landoscript worker type and payload builder r?#releng-reviewers!

This patch currently includes the payload_builder implementation as well. I'll be changing that, and implementing it in the appropriate descendant commits instead.

Comment 8

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: switch android-l10n tasks to landoscript r?#releng-reviewers!

Comment 9

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: switch l10n-bump tasks to landoscript r?#releng-reviewers!

Comment 10

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: switch merge-automation tasks to landoscript r?#releng-reviewers!

Comment 11

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: switch release-early-tagging to landoscript r?#releng-reviewers!

Comment 12

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: switch release-version-bump to landoscript r?#releng-reviewers!

Comment 13

[BMO Github Automation]

Authored by https://github.com/bhearsum
https://github.com/mozilla-releng/fxci-config/commit/ba22ba7204f79f57fa4f0eb5053537454e9c354b
[main] bug 1948315: grant scopes for landoscript repos & actions (#352)

Comment 14

[[e-mail] (:bhearsum)]

sigh..no...this is not done

Comment 15

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: rename `release_version_bump` transform to reflect reality r?#releng-reviewers!

This transform may have been specific to release_version_bump at some point, but it's certainly not at this point. It almost seems silly for it to exist at all, but I was unable to replace it with task-context, so this rename will have to do. (There are changes in descendent revisions that make it exclusive to landoscript.)

Comment 16

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: rename `release_version_bump` transform to reflect reality

This transform may have been specific to release_version_bump at some point, but it's certainly not at this point, so rename it.

It almost seems silly for it to exist at all, but I was unable to replace it with task-context, so this rename will have to do.

Original Revision: https://phabricator.services.mozilla.com/D246817

Comment 17

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: add landoscript worker type and payload builder

The payload builder is created here, but fully stubbed out. Descendent revisions will implement it.

Original Revision: https://phabricator.services.mozilla.com/D246669

Comment 18

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: switch l10n-bump tasks to landoscript

Aside from the addition of scopes and lando-repo, most of the changes to the kind are dropping attributes that do not add to the payload (bump, tags, push, version-path). push theoretically could have been supported, but I don't see any need for it seeing as all landoscript actions support a dry_run mode. (We don't actually ever use it for l10n-bump, but it's there if we want to in the future...)

Tested on try in: https://treeherder.mozilla.org/jobs?repo=try&searchStr=l10n-bump&revision=2ab614bee5807309146d40188ba8766838205e98

Original Revision: https://phabricator.services.mozilla.com/D246671

Comment 19

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: switch release-early-tagging to landoscript

Tested on try in: https://treeherder.mozilla.org/jobs?repo=try&searchStr=early-tagging&revision=83b0a833fe77e0a01510e7178f5b912300541fe4

Original Revision: https://phabricator.services.mozilla.com/D246673

Comment 20

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: switch release-version-bump to landoscript

Tested on try in: https://treeherder.mozilla.org/jobs?repo=try&searchStr=version-bump&revision=83b0a833fe77e0a01510e7178f5b912300541fe4

Original Revision: https://phabricator.services.mozilla.com/D246674

Comment 21

[[e-mail] (:bhearsum)]

Attachment: WIP: Bug 1948315: switch merge-automation tasks to landoscript

Similar to earlier revisions in this stack, most of the changes to the kind (and some of the other files) are just dropping now-pointless attributes like ssh-user-alias. The biggest thing of note here is the change to the bump-esr128 merge config to ensure the esr suffix is included in the display version. This fixes a bug that was present even in treescript.

Original Revision: https://phabricator.services.mozilla.com/D246672

Comment 22

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: rename `release_version_bump` transform to reflect reality

This transform may have been specific to release_version_bump at some point, but it's certainly not at this point, so rename it.

It almost seems silly for it to exist at all, but I was unable to replace it with task-context, so this rename will have to do.

Original Revision: https://phabricator.services.mozilla.com/D246817

Comment 23

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: add landoscript worker type and payload builder

The payload builder is created here, but fully stubbed out. Descendent revisions will implement it.

Original Revision: https://phabricator.services.mozilla.com/D246669

Comment 24

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: switch l10n-bump tasks to landoscript

Aside from the addition of scopes and lando-repo, most of the changes to the kind are dropping attributes that do not add to the payload (bump, tags, push, version-path). push theoretically could have been supported, but I don't see any need for it seeing as all landoscript actions support a dry_run mode. (We don't actually ever use it for l10n-bump, but it's there if we want to in the future...)

Tested on try in: https://treeherder.mozilla.org/jobs?repo=try&searchStr=l10n-bump&revision=2ab614bee5807309146d40188ba8766838205e98

Original Revision: https://phabricator.services.mozilla.com/D246671

Comment 25

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: switch release-early-tagging to landoscript

Tested on try in: https://treeherder.mozilla.org/jobs?repo=try&searchStr=early-tagging&revision=83b0a833fe77e0a01510e7178f5b912300541fe4

Original Revision: https://phabricator.services.mozilla.com/D246673

Comment 26

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: switch release-version-bump to landoscript

Tested on try in: https://treeherder.mozilla.org/jobs?repo=try&searchStr=version-bump&revision=83b0a833fe77e0a01510e7178f5b912300541fe4

Original Revision: https://phabricator.services.mozilla.com/D246674

Comment 27

[Phabricator Automation]

esr115 Uplift Approval Request

• User impact if declined: n/a
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: medium
• Explanation of risk level: it notably changes release impacting tasks
• String changes made/needed: n/a
• Is Android affected?: no

Comment 28

[[e-mail] (:bhearsum)]

Comment on attachment 9481300 [details]
Bug 1948315: rename release_version_bump transform to reflect reality r?#releng-reviewers!

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: n/a
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce: n/a
• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): We need these to continue to have working releases.
• String changes made/needed: n/a
• Is Android affected?: No

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: n/a
• User impact if declined: n/a
• Fix Landed on Version:
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): We need these to continue to have working releases.

Comment 29

[[e-mail] (:bhearsum)]

Comment on attachment 9481013 [details]
Bug 1948315: switch release-version-bump to landoscript r?#releng-reviewers!

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency:
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed:
• Is Android affected?: Yes

Comment 30

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e83c576b567f
rename `release_version_bump` transform to reflect reality r=releng-reviewers,taskgraph-reviewers,ahal
https://hg.mozilla.org/integration/autoland/rev/b6329fba21e7
add landoscript worker type and payload builder r=releng-reviewers,taskgraph-reviewers,ahal
https://hg.mozilla.org/integration/autoland/rev/45060e0d2108
switch android-l10n tasks to landoscript r=releng-reviewers,taskgraph-reviewers,ahal
https://hg.mozilla.org/integration/autoland/rev/87ef4284f82b
switch l10n-bump tasks to landoscript r=releng-reviewers,taskgraph-reviewers,ahal
https://hg.mozilla.org/integration/autoland/rev/fcf88392e32e
switch release-early-tagging to landoscript r=releng-reviewers,taskgraph-reviewers,ahal
https://hg.mozilla.org/integration/autoland/rev/f86d0ed827f3
switch release-version-bump to landoscript r=releng-reviewers,taskgraph-reviewers,ahal

Comment 31

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: rename `release_version_bump` transform to reflect reality r?#releng-reviewers!

This transform may have been specific to release_version_bump at some point, but it's certainly not at this point, so rename it.

It almost seems silly for it to exist at all, but I was unable to replace it with task-context, so this rename will have to do.

Comment 32

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: add landoscript worker type and payload builder r?#releng-reviewers!

The payload builder is created here, but fully stubbed out. Descendent revisions will implement it.

Comment 33

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: switch android-l10n tasks to landoscript r?#releng-reviewers!

Aside from the obvious addition of scopes and lando-repo the only things of note are:

• Dropping ignore-closed-tree for import. Because we always ignore the closed tree in it, the action in landoscript doesn't even support checking it.
• from-repo-url being replaced with from-branch in sync. In the landoscript world, this is just a branch that we look up the concrete repository for in Lando.

Tested on try in: https://treeherder.mozilla.org/jobs?repo=try&searchStr=android-l10n&revision=2ab614bee5807309146d40188ba8766838205e98

Comment 34

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: switch l10n-bump tasks to landoscript r?#releng-reviewers!

Aside from the addition of scopes and lando-repo, most of the changes to the kind are dropping attributes that do not add to the payload (bump, tags, push, version-path). push theoretically could have been supported, but I don't see any need for it seeing as all landoscript actions support a dry_run mode. (We don't actually ever use it for l10n-bump, but it's there if we want to in the future...)

Tested on try in: https://treeherder.mozilla.org/jobs?repo=try&searchStr=l10n-bump&revision=2ab614bee5807309146d40188ba8766838205e98

Comment 35

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: switch release-early-tagging to landoscript r?#releng-reviewers!

Tested on try in: https://treeherder.mozilla.org/jobs?repo=try&searchStr=early-tagging&revision=83b0a833fe77e0a01510e7178f5b912300541fe4

Comment 36

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: switch release-version-bump to landoscript r?#releng-reviewers!

Tested on try in: https://treeherder.mozilla.org/jobs?repo=try&searchStr=version-bump&revision=83b0a833fe77e0a01510e7178f5b912300541fe4

Comment 37

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: rename `release_version_bump` transform to reflect reality r?#releng-reviewers!

This transform may have been specific to release_version_bump at some point, but it's certainly not at this point, so rename it.

It almost seems silly for it to exist at all, but I was unable to replace it with task-context, so this rename will have to do.

Comment 38

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: add landoscript worker type and payload builder r?#releng-reviewers!

The payload builder is created here, but fully stubbed out. Descendent revisions will implement it.

Comment 39

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: switch android-l10n tasks to landoscript r?#releng-reviewers!

Aside from the obvious addition of scopes and lando-repo the only things of note are:

• Dropping ignore-closed-tree for import. Because we always ignore the closed tree in it, the action in landoscript doesn't even support checking it.
• from-repo-url being replaced with from-branch in sync. In the landoscript world, this is just a branch that we look up the concrete repository for in Lando.

Tested on try in: https://treeherder.mozilla.org/jobs?repo=try&searchStr=android-l10n&revision=2ab614bee5807309146d40188ba8766838205e98

Comment 40

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: switch l10n-bump tasks to landoscript r?#releng-reviewers!

Aside from the addition of scopes and lando-repo, most of the changes to the kind are dropping attributes that do not add to the payload (bump, tags, push, version-path). push theoretically could have been supported, but I don't see any need for it seeing as all landoscript actions support a dry_run mode. (We don't actually ever use it for l10n-bump, but it's there if we want to in the future...)

Tested on try in: https://treeherder.mozilla.org/jobs?repo=try&searchStr=l10n-bump&revision=2ab614bee5807309146d40188ba8766838205e98

Comment 41

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: switch release-early-tagging to landoscript r?#releng-reviewers!

Tested on try in: https://treeherder.mozilla.org/jobs?repo=try&searchStr=early-tagging&revision=83b0a833fe77e0a01510e7178f5b912300541fe4

Comment 42

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: switch release-version-bump to landoscript r?#releng-reviewers!

Tested on try in: https://treeherder.mozilla.org/jobs?repo=try&searchStr=version-bump&revision=83b0a833fe77e0a01510e7178f5b912300541fe4

Comment 43

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/5326e6fcdca4
https://hg.mozilla.org/releases/mozilla-beta/rev/36aa380d067a
https://hg.mozilla.org/releases/mozilla-beta/rev/aafb50ff924d
https://hg.mozilla.org/releases/mozilla-beta/rev/11c18d038c0d
https://hg.mozilla.org/releases/mozilla-beta/rev/83062f3c2c14
https://hg.mozilla.org/releases/mozilla-beta/rev/4d1a8a4263e1

Comment 44

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/8412029b58f8
https://hg.mozilla.org/releases/mozilla-release/rev/88a453ca1f68
https://hg.mozilla.org/releases/mozilla-release/rev/ab65d1851c31
https://hg.mozilla.org/releases/mozilla-release/rev/a60d0286cd57
https://hg.mozilla.org/releases/mozilla-release/rev/03d3356eef68
https://hg.mozilla.org/releases/mozilla-release/rev/2e3e54cf8c01

Comment 45

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: fix python linting issue r?diannaS!

Comment 46

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/de2f99ba623c

Comment 47

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e83c576b567f
https://hg.mozilla.org/mozilla-central/rev/b6329fba21e7
https://hg.mozilla.org/mozilla-central/rev/45060e0d2108
https://hg.mozilla.org/mozilla-central/rev/87ef4284f82b
https://hg.mozilla.org/mozilla-central/rev/fcf88392e32e
https://hg.mozilla.org/mozilla-central/rev/f86d0ed827f3

Comment 48

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: rename `release_version_bump` transform to reflect reality r?#release-managers!

This transform may have been specific to release_version_bump at some point, but it's certainly not at this point, so rename it.

It almost seems silly for it to exist at all, but I was unable to replace it with task-context, so this rename will have to do.

Comment 49

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: add landoscript worker type and payload builder r?#release-managers!

The payload builder is created here, but fully stubbed out. Descendent revisions will implement it.

Comment 50

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: switch android-l10n tasks to landoscript r?#release-managers!

Aside from the obvious addition of scopes and lando-repo the only things of note are:

• Dropping ignore-closed-tree for import. Because we always ignore the closed tree in it, the action in landoscript doesn't even support checking it.
• from-repo-url being replaced with from-branch in sync. In the landoscript world, this is just a branch that we look up the concrete repository for in Lando.

Tested on try in: https://treeherder.mozilla.org/jobs?repo=try&searchStr=android-l10n&revision=2ab614bee5807309146d40188ba8766838205e98

Comment 51

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: switch l10n-bump tasks to landoscript r?#release-managers!

Aside from the addition of scopes and lando-repo, most of the changes to the kind are dropping attributes that do not add to the payload (bump, tags, push, version-path). push theoretically could have been supported, but I don't see any need for it seeing as all landoscript actions support a dry_run mode. (We don't actually ever use it for l10n-bump, but it's there if we want to in the future...)

Tested on try in: https://treeherder.mozilla.org/jobs?repo=try&searchStr=l10n-bump&revision=2ab614bee5807309146d40188ba8766838205e98

Comment 52

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: switch release-early-tagging to landoscript r?#release-managers!

Tested on try in: https://treeherder.mozilla.org/jobs?repo=try&searchStr=early-tagging&revision=83b0a833fe77e0a01510e7178f5b912300541fe4

Comment 53

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: switch release-version-bump to landoscript r?#release-managers!

Tested on try in: https://treeherder.mozilla.org/jobs?repo=try&searchStr=version-bump&revision=83b0a833fe77e0a01510e7178f5b912300541fe4

Comment 54

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: rename `release_version_bump` transform to reflect reality r?#release-managers!

This transform may have been specific to release_version_bump at some point, but it's certainly not at this point, so rename it.

It almost seems silly for it to exist at all, but I was unable to replace it with task-context, so this rename will have to do.

Comment 55

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: add landoscript worker type and payload builder r?#release-managers!

The payload builder is created here, but fully stubbed out. Descendent revisions will implement it.

Comment 56

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: switch l10n-bump tasks to landoscript r?#release-managers!

Aside from the addition of scopes and lando-repo, most of the changes to the kind are dropping attributes that do not add to the payload (bump, tags, push, version-path). push theoretically could have been supported, but I don't see any need for it seeing as all landoscript actions support a dry_run mode. (We don't actually ever use it for l10n-bump, but it's there if we want to in the future...)

Tested on try in: https://treeherder.mozilla.org/jobs?repo=try&searchStr=l10n-bump&revision=2ab614bee5807309146d40188ba8766838205e98

Comment 57

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: switch release-early-tagging to landoscript r?#release-managers!

Tested on try in: https://treeherder.mozilla.org/jobs?repo=try&searchStr=early-tagging&revision=83b0a833fe77e0a01510e7178f5b912300541fe4

Comment 58

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: switch release-version-bump to landoscript r?#release-managers!

Tested on try in: https://treeherder.mozilla.org/jobs?repo=try&searchStr=version-bump&revision=83b0a833fe77e0a01510e7178f5b912300541fe4

Comment 59

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/8703dd26cae3
https://hg.mozilla.org/releases/mozilla-esr128/rev/2b9ff1be72d7
https://hg.mozilla.org/releases/mozilla-esr128/rev/cec4aed73501
https://hg.mozilla.org/releases/mozilla-esr128/rev/75bf95ad8872
https://hg.mozilla.org/releases/mozilla-esr128/rev/76a312cff298
https://hg.mozilla.org/releases/mozilla-esr128/rev/390bb071e4bc

Comment 60

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/073d527ad981
https://hg.mozilla.org/releases/mozilla-esr115/rev/87e1903cdd14
https://hg.mozilla.org/releases/mozilla-esr115/rev/d1ea99d4ae03
https://hg.mozilla.org/releases/mozilla-esr115/rev/a025789feb2d
https://hg.mozilla.org/releases/mozilla-esr115/rev/f44fc7613a84

Comment 61

[[e-mail] (:bhearsum)]

still not done. need to convert merge-automation tasks still.

Comment 62

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: use correct `to-branch` in merge-automation on try r?#releng-reviewers!

Comment 63

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: drop unnecessary scopes from landoscript tasks r?#releng-reviewers!

An earlier revision in this stack will automatically add them in the payload builder

Comment 64

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: switch merge-automation tasks to landoscript r?#releng-reviewers!

Similar to when other tasks were switched to landoscript, most of the changes to the kind (and some of the other files) are just dropping now-pointless attributes like ssh-user-alias.

There's two primary things of note here:

• The change to the bump-esr128 merge config to ensure the esr suffix is included in the display version. This fixes a bug that was present even in treescript.
• The new logic in the payload builder to add the correct scopes. This should work for all landoscript tasks, and I will be removing the scopes in the other kinds in a descendent revision.

Comment 65

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: use correct `to-branch` in merge-automation on try r?#releng-reviewers!

Comment 66

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: drop unnecessary scopes from landoscript tasks r?#releng-reviewers!

An earlier revision in this stack will automatically add them in the payload builder

Comment 67

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: change non-merge-automation landoscript tasks to use correct lando repo on try r?#releng-reviewers!

This is not technically related to the bug at hand, but the clean up may as well get done here.

Comment 69

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2a388fd0149
switch merge-automation tasks to landoscript r=releng-reviewers,taskgraph-reviewers,ahal
https://hg.mozilla.org/integration/autoland/rev/c3d40986f664
use correct `to-branch` in merge-automation on try r=releng-reviewers,jcristau
https://hg.mozilla.org/integration/autoland/rev/babd7f7a9076
drop unnecessary scopes from landoscript tasks r=releng-reviewers,jcristau
https://hg.mozilla.org/integration/autoland/rev/70514894bc39
change non-merge-automation landoscript tasks to use correct lando repo on try r=releng-reviewers,jcristau

Comment 70

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: switch merge-automation tasks to landoscript r?#release-managers!

Similar to when other tasks were switched to landoscript, most of the changes to the kind (and some of the other files) are just dropping now-pointless attributes like ssh-user-alias.

There's two primary things of note here:

• The change to the bump-esr128 merge config to ensure the esr suffix is included in the display version. This fixes a bug that was present even in treescript.
• The new logic in the payload builder to add the correct scopes. This should work for all landoscript tasks, and I will be removing the scopes in the other kinds in a descendent revision.

Comment 71

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: use correct `to-branch` in merge-automation on try r?#release-managers!

Comment 72

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: drop unnecessary scopes from landoscript tasks r?#release-managers!

An earlier revision in this stack will automatically add them in the payload builder

Comment 73

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: change non-merge-automation landoscript tasks to use correct lando repo on try r?#release-managers!

This is not technically related to the bug at hand, but the clean up may as well get done here.

Comment 74

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: n/a
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: low
• Explanation of risk level: testing on try and locally
• String changes made/needed: no
• Is Android affected?: no

Comment 75

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: switch merge-automation tasks to landoscript r?#release-managers!

Similar to when other tasks were switched to landoscript, most of the changes to the kind (and some of the other files) are just dropping now-pointless attributes like ssh-user-alias.

There's two primary things of note here:

• The change to the bump-esr128 merge config to ensure the esr suffix is included in the display version. This fixes a bug that was present even in treescript.
• The new logic in the payload builder to add the correct scopes. This should work for all landoscript tasks, and I will be removing the scopes in the other kinds in a descendent revision.

Comment 76

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: use correct `to-branch` in merge-automation on try r?#release-managers!

Comment 77

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: drop unnecessary scopes from landoscript tasks r?#release-managers!

An earlier revision in this stack will automatically add them in the payload builder

Comment 78

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: change non-merge-automation landoscript tasks to use correct lando repo on try r?#release-managers!

This is not technically related to the bug at hand, but the clean up may as well get done here.

Comment 79

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: switch merge-automation tasks to landoscript r?#release-managers!

Similar to when other tasks were switched to landoscript, most of the changes to the kind (and some of the other files) are just dropping now-pointless attributes like ssh-user-alias.

There's two primary things of note here:

• The change to the bump-esr128 merge config to ensure the esr suffix is included in the display version. This fixes a bug that was present even in treescript.
• The new logic in the payload builder to add the correct scopes. This should work for all landoscript tasks, and I will be removing the scopes in the other kinds in a descendent revision.

Comment 80

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: use correct `to-branch` in merge-automation on try r?#release-managers!

Comment 81

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: drop unnecessary scopes from landoscript tasks r?#release-managers!

An earlier revision in this stack will automatically add them in the payload builder

Comment 82

[[e-mail] (:bhearsum)]

Attachment: Bug 1948315: change non-merge-automation landoscript tasks to use correct lando repo on try r?#release-managers!

This is not technically related to the bug at hand, but the clean up may as well get done here.

Comment 83

[Phabricator Automation]

firefox-esr128 Uplift Approval Request

• User impact if declined: n/a
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: low
• Explanation of risk level: testing on try & locally
• String changes made/needed: n/a
• Is Android affected?: no

Comment 84

[Phabricator Automation]

firefox-esr115 Uplift Approval Request

• User impact if declined: n/a
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: low
• Explanation of risk level: tested on try/locally
• String changes made/needed: n/a
• Is Android affected?: no

Comment 85

[[e-mail] (:bhearsum)]

With the merge-automation changes having landed I think it's time to close this bug.

It's possible we may need follow-up fixes: most notably for release-to-esr and bump-esrXXX actions that I haven't been able to fully test yet, but this bug is far too big already, and those are best done in specific bugs.

Comment 86

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d2a388fd0149
https://hg.mozilla.org/mozilla-central/rev/c3d40986f664
https://hg.mozilla.org/mozilla-central/rev/babd7f7a9076
https://hg.mozilla.org/mozilla-central/rev/70514894bc39

Comment 87

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/5f0673f92e47
https://hg.mozilla.org/releases/mozilla-beta/rev/9bbdf4278fdc
https://hg.mozilla.org/releases/mozilla-beta/rev/06b4e44d09a9
https://hg.mozilla.org/releases/mozilla-beta/rev/f751f3eba06e

Comment 88

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/7a56754c7f0a
https://hg.mozilla.org/releases/mozilla-esr128/rev/4fc12920aed0
https://hg.mozilla.org/releases/mozilla-esr128/rev/6fa731f13080
https://hg.mozilla.org/releases/mozilla-esr128/rev/fee4aa6268cc

Comment 89

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/05ae229f34bd
https://hg.mozilla.org/releases/mozilla-esr115/rev/4b5230fce8a3
https://hg.mozilla.org/releases/mozilla-esr115/rev/8dd3d3ff20e3
https://hg.mozilla.org/releases/mozilla-esr115/rev/077f2fd0d81f

Comment 90

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/cf2f1b9e8c2c
https://hg.mozilla.org/releases/mozilla-esr128/rev/e5a380a1b3f1
https://hg.mozilla.org/releases/mozilla-esr128/rev/57a2c961cb25
https://hg.mozilla.org/releases/mozilla-esr128/rev/c426ca3acef7
https://hg.mozilla.org/releases/mozilla-esr128/rev/060538772c62
https://hg.mozilla.org/releases/mozilla-esr128/rev/2fa5b6e255f9
https://hg.mozilla.org/releases/mozilla-esr128/rev/638d166a420e
https://hg.mozilla.org/releases/mozilla-esr128/rev/4b9a04829b0d
https://hg.mozilla.org/releases/mozilla-esr128/rev/541fa9469aa2
https://hg.mozilla.org/releases/mozilla-esr128/rev/bf9141eda40a

Comment 91

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/6fefd70ae427
https://hg.mozilla.org/releases/mozilla-esr115/rev/2b5bd1dc560a
https://hg.mozilla.org/releases/mozilla-esr115/rev/ac4c7a610f43
https://hg.mozilla.org/releases/mozilla-esr115/rev/302b65caacd8
https://hg.mozilla.org/releases/mozilla-esr115/rev/14bef960be90
https://hg.mozilla.org/releases/mozilla-esr115/rev/d2fe3689235f
https://hg.mozilla.org/releases/mozilla-esr115/rev/4447afa44972
https://hg.mozilla.org/releases/mozilla-esr115/rev/617c37fe8f4b
https://hg.mozilla.org/releases/mozilla-esr115/rev/b650111dba6e