1948427 - Compose Window search bar text "Replace..." can overwrite the "Whole words" option

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect, P3)

Description

[Jim Garrison]

Attachment: Shows overwriting

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:135.0) Gecko/20100101 Firefox/135.0

Steps to reproduce:

Version is 128.7

In an open compose window open the search bar (Ctrl+F), search for a string that is present in the message. This adds a "Replace..." option in the search bar.

Actual results:

In a normal-sized window for my 2560x1440 display the text of "Replace..." will partially overwrite the "Whole words" option to its left (see screenshots). If I widen the window enough to contain all the options then the display is OK.

Expected results:

Text should not be overwritten

Comment 1

[Jim Garrison]

Attachment: Shows result with extra wide window - no overwriting

Comment 2

[Corey Bryant]

Confirmed on 136.0b2

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Bug 1948427 - Fix the flexing of the replace button on the findbar. r=#thunderbird-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b87c5af9e05a
Fix the flexing of the replace button on the findbar. r=mkmelin

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 9466485 [details]
Bug 1948427 - Fix the flexing of the replace button on the findbar. r=#thunderbird-reviewers

[User impact if declined]

• In compose window on the findbar the "Replace" button can be overwritten by other text when the window is narrow.

[Is this code covered by automated tests?]

• No

[Has the fix been verified in Daily? (or Beta for an ESR uplift?)]

• Landed on C-C.

[Needs manual test from QA?]

• Yes.
• Open the compose window, fill in some text and press CTRL-F (CMD-F on Mac). Make the window narrow and check that the "Replace" button isn't overwritten. It can be that the bar can be cut off at the end of the window (not a bug).

[List of other uplifts needed]

• None.

[Risk to taking this patch]

• Low.

[Why is the change risky/not risky? (and alternatives if risky)]

• small CSS change.

[String changes made/needed]

• No.

Comment 6

[Corey Bryant]

Comment on attachment 9466485 [details]
Bug 1948427 - Fix the flexing of the replace button on the findbar. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 7

[Corey Bryant]

[Needs manual test from QA?]

• Yes.
• Open the compose window, fill in some text and press CTRL-F (CMD-F on Mac). Make the window narrow and check that the "Replace" button isn't overwritten. It can be that the bar can be cut off at the end of the window (not a bug).

Richard, thanks for the fix. This seems simple enough to test on beta. Would you be able to test it once it lands in beta? I'm not sure we need to get QA involved.

Comment 8

[Richard Marti (:Paenglab)]

(In reply to Corey Bryant from comment #7)

Richard, thanks for the fix. This seems simple enough to test on beta. Would you be able to test it once it lands in beta? I'm not sure we need to get QA involved.

I can do it.

Comment 9

[Corey Bryant]

Thunderbird 136.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/c6624e0573cf

Comment 10

[Richard Marti (:Paenglab)]

Tested Thunderbird 136.0b3 and the button is no more squished.

Comment 11

[Corey Bryant]

Comment on attachment 9466485 [details]
Bug 1948427 - Fix the flexing of the replace button on the findbar. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr128