1948581 - Console Network log Response Raw toggle doesn't work anymore

Status: RESOLVED FIXED

(DevTools :: Console, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Clicking on it, we get an error: JavaScript error: resource://devtools/client/netmonitor/src/components/request-details/ResponsePanel.js, line 367: TypeError: this.props.setDefaultRawResponse is not a function

Probably regressed in Bug 1555647

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1948581 - [devtools] Fix Network messages raw response toggle. r=#devtools.

This is only to make the toggle works as before,
it doesn't handle persisting the toggle state
like in the Netmonitor.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1555647

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9045d63e5c70
[devtools] Fix Network messages raw response toggle. r=devtools-reviewers,bomsy.

Comment 4

[agoloman]

Backed out for causing dt failures @browser_webconsole_network_messages_html_preview.js.

• Backout link
• Push with failures
• Failure Log

Comment 5

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/9045d63e5c70

Comment 6

[Serban Stanca [:SerbanS]]

Backout merged in central: https://hg.mozilla.org/mozilla-central/rev/c274bdcbae22863127636f748c71474512f1039d

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

I'm looking into this

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e443ab3b192f
[devtools] Fix Network messages raw response toggle. r=devtools-reviewers,bomsy.

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e443ab3b192f

Comment 10

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1948581 - [devtools] Fix Network messages raw response toggle. r=#devtools.

This is only to make the toggle works as before,
it doesn't handle persisting the toggle state
like in the Netmonitor.
We also pass targetSearchResult to TabboxPanel to avoid
unnecessary re-renders that were messing up the test.

Original Revision: https://phabricator.services.mozilla.com/D238416

Comment 11

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: can't see the raw response of a network request in the console
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: -
• Risk associated with taking this patch: low
• Explanation of risk level: couple lines, devtools-only patch, covered by automated test
• String changes made/needed: -
• Is Android affected?: no

Comment 12

[Donal Meehan [:dmeehan]]

:nchevobbe I see this picked up a regression Bug 1949298.
I see it has a fix, but could you add it in a stack with this? I could take then both into beta later.

Comment 13

[Donal Meehan [:dmeehan]]

I will land this on beta so it will make the final beta build. We can follow-up on the Tier 2 regression fix uplift later.

Comment 14

[Donal Meehan [:dmeehan]]

https://phabricator.services.mozilla.com/D238915#8254751 the patch failed to land in beta due to conflicts caused by Bug 1849920

Comment 15

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Donal Meehan [:dmeehan] from comment #12)

:nchevobbe I see this picked up a regression Bug 1949298.
I see it has a fix, but could you add it in a stack with this? I could take then both into beta later.

sorry for missing this yesterday. The failure is only an a11y check failure, which is tier 2, and doesn't reveal any new issue. I was told those a11y_checks jobs are not run on beta, so maybe it's fine?
I'll uplift it anyway

(In reply to Donal Meehan [:dmeehan] from comment #14)

https://phabricator.services.mozilla.com/D238915#8254751 the patch failed to land in beta due to conflicts caused by Bug 1849920

I rebase the patch against latest beta and pushed the patch to phab

Comment 16

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/5a23d182a312