1949298 - Perma [tier 2] a11y devtools/client/webconsole/test/browser/browser_webconsole_network_messages_html_preview.js | Interactive elements must be labeled: id: raw-response-checkbox, tagName: INPUT, className: devtools-checkbox-toggle

Status: RESOLVED FIXED

(DevTools :: Console, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: agoloman [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=495630308&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/PWgANdqrQTO400WciYDz-g/runs/1/artifacts/public/logs/live_backing.log

---

[task 2025-02-19T11:26:45.612Z] 11:26:45     INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_webconsole_eval_sources.js | The message does have a location link - 
[task 2025-02-19T11:26:45.612Z] 11:26:45     INFO - checking click on node location
[task 2025-02-19T11:26:45.613Z] 11:26:45     INFO - Buffered messages logged at 11:26:43
[task 2025-02-19T11:26:45.613Z] 11:26:45     INFO - Waiting for event: 'source-in-debugger-opened' on [object Object].
[task 2025-02-19T11:26:45.613Z] 11:26:45     INFO - Buffered messages finished
[task 2025-02-19T11:26:45.614Z] 11:26:45     INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_webconsole_eval_sources.js | Node is not accessible via accessibility API: id: , tagName: SPAN, className: frame-link-filename - 
[task 2025-02-19T11:26:45.614Z] 11:26:45     INFO - Stack trace:
[task 2025-02-19T11:26:45.614Z] 11:26:45     INFO - chrome://mochikit/content/browser-test.js:test_ok:1626
[task 2025-02-19T11:26:45.614Z] 11:26:45     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:a11yFail:756
[task 2025-02-19T11:26:45.614Z] 11:26:45     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertCanBeClicked:1165
[task 2025-02-19T11:26:45.615Z] 11:26:45     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:runIfA11YChecks/this.AccessibilityUtils:1141
[task 2025-02-19T11:26:45.615Z] 11:26:45     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:handleEvent:1258
[task 2025-02-19T11:26:45.615Z] 11:26:45     INFO - chrome://mochikit/content/tests/SimpleTest/EventUtils.js:sendMouseEvent:308
[task 2025-02-19T11:26:45.615Z] 11:26:45     INFO - chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/head.js:checkClickOnNode:591
[task 2025-02-19T11:26:45.615Z] 11:26:45     INFO - chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/head.js:testOpenInDebugger:559
[task 2025-02-19T11:26:45.615Z] 11:26:45     INFO - chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/browser_webconsole_eval_sources.js:null:28
[task 2025-02-19T11:26:45.615Z] 11:26:45     INFO - chrome://mochikit/content/browser-test.js:handleTask:1170
[task 2025-02-19T11:26:45.615Z] 11:26:45     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1242
[task 2025-02-19T11:26:45.615Z] 11:26:45     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1383
[task 2025-02-19T11:26:45.615Z] 11:26:45     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1159
[task 2025-02-19T11:26:45.615Z] 11:26:45     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2025-02-19T11:26:45.615Z] 11:26:45     INFO - Got event: 'source-in-debugger-opened' on [object Object].
[task 2025-02-19T11:26:45.615Z] 11:26:45     INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_webconsole_eval_sources.js | source line found ("1") - 
<...>
[task 2025-02-19T11:28:51.471Z] 11:28:51     INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_webconsole_network_messages_html_preview.js | Raw toggle isn't checked by default - 
[task 2025-02-19T11:28:51.472Z] 11:28:51     INFO - Buffered messages finished
[task 2025-02-19T11:28:51.474Z] 11:28:51     INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_webconsole_network_messages_html_preview.js | Interactive elements must be labeled: id: raw-response-checkbox, tagName: INPUT, className: devtools-checkbox-toggle - 
[task 2025-02-19T11:28:51.474Z] 11:28:51     INFO - Stack trace:
[task 2025-02-19T11:28:51.475Z] 11:28:51     INFO - chrome://mochikit/content/browser-test.js:test_ok:1626
[task 2025-02-19T11:28:51.475Z] 11:28:51     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:a11yFail:756
[task 2025-02-19T11:28:51.476Z] 11:28:51     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertLabelled:970
[task 2025-02-19T11:28:51.476Z] 11:28:51     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertCanBeClicked:1177
[task 2025-02-19T11:28:51.476Z] 11:28:51     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:runIfA11YChecks/this.AccessibilityUtils:1141
[task 2025-02-19T11:28:51.477Z] 11:28:51     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:handleEvent:1258
[task 2025-02-19T11:28:51.477Z] 11:28:51     INFO - chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/browser_webconsole_network_messages_html_preview.js:expandNetworkRequestAndWaitForHtmlView:178
[task 2025-02-19T11:28:51.477Z] 11:28:51     INFO - chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/browser_webconsole_network_messages_html_preview.js:task:97
[task 2025-02-19T11:28:51.478Z] 11:28:51     INFO - chrome://mochikit/content/browser-test.js:handleTask:1170
[task 2025-02-19T11:28:51.478Z] 11:28:51     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1242
[task 2025-02-19T11:28:51.478Z] 11:28:51     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1383
[task 2025-02-19T11:28:51.479Z] 11:28:51     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1159
[task 2025-02-19T11:28:51.479Z] 11:28:51     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2025-02-19T11:28:51.537Z] 11:28:51     INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_webconsole_network_messages_html_preview.js | The CodeMirror instance is rendered - 

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1948581

:nchevobbe, since you are the author of the regressor, bug 1948581, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Cosmin Sabou [:CosminS]]

20904	11:28:51 INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_webconsole_network_messages_html_preview.js | Interactive elements must be labeled: id: raw-response-checkbox, tagName: INPUT, className: devtools-checkbox-toggle -
20956	11:28:52 INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_webconsole_network_messages_html_preview.js | Interactive elements must be labeled: id: raw-response-checkbox, tagName: INPUT, className: devtools-checkbox-toggle -

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1949298 - [devtools] Remove unnecessary Netmonitor Raw toggle <label> "for" attribute. r=#devtools.

The label already wraps the input, so we don't need to also
have this attribute.
This was causing troubles in the console where the network
detail panel can be included multiple times; the label "for"
attribute would then refer to the first item with such id,
making its actual child input without label.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e58ee022ce0
[devtools] Remove unnecessary Netmonitor Raw toggle <label> "for" attribute. r=devtools-reviewers,bomsy.

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing mac perma leack failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/9c10d703ac29c022856d20b7fffa0c5e5ba4daf5

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | leakcheck | default 8424 bytes leaked (AddrHostRecord, CondVar, DNSListenerProxy, DnsThreadListener, MessageLoop::EventTarget, ...)

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Sandor Molnar[:smolnar] from comment #5)

Backed out for causing mac perma leack failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/9c10d703ac29c022856d20b7fffa0c5e5ba4daf5

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | leakcheck | default 8424 bytes leaked (AddrHostRecord, CondVar, DNSListenerProxy, DnsThreadListener, MessageLoop::EventTarget, ...)

my patch only removes a for attributes on some elements. Are you positive it did trigger the failure?

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Also the tests that are failing are not even DevTools test and this is only impacting the DevTools UI, so i'd be very surprised if this patch caused all those failures

Comment 8

[Sandor Molnar[:smolnar]]

I did some retriggers and it seems they turned green
Will reland your patch and sorry for the inconvenience

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3bc96da6e5a
[devtools] Remove unnecessary Netmonitor Raw toggle <label> "for" attribute. r=devtools-reviewers,bomsy.

Comment 10

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/a3bc96da6e5a

Comment 11

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1949298 - [devtools] Remove unnecessary Netmonitor Raw toggle <label> "for" attribute. r=#devtools.

The label already wraps the input, so we don't need to also
have this attribute.
This was causing troubles in the console where the network
detail panel can be included multiple times; the label "for"
attribute would then refer to the first item with such id,
making its actual child input without label.

Original Revision: https://phabricator.services.mozilla.com/D238916

Comment 12

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: None, but tier 2 test failures when D238915 lands
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: -
• Risk associated with taking this patch: low
• Explanation of risk level: fixing test failure, removing a superfluous attribute
• String changes made/needed: -
• Is Android affected?: no

Comment 13

[Intermittent Failures Robot]

Summary

6 failures in 4340 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 6

Platform and build breakdown:

• linux1804-64-qr: 6
  • opt: 6

Table

	a11y-checks
linux1804-64-qr--/opt	6

For more details, see:

https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1949298&startday=2025-02-17&endday=2025-02-23&tree=all