1948633 - [composable toolbar] Display Toolbar - show pageOrigin from from DisplayState

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, task, P2)

Description

[Petru-Mugurel Lingurar [:petru]]

An important functionality of the BrowserToolbar is to show information about the current webpage - the title and URL or an optional hint.
Refer to the current implementation of OriginView for the functionality and scenarios needing to be supported.

For configuring the data to be displayed DisplayState should allow passing a pageOrigin object with the following properties:

data class PageOrigin(
	val title: String?,
	val url: String?,
	val hint: String?,
	val onClick: BrowserToolbarEvent?,
	val onLongClick: BrowserToolbarEvent?,
)

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1948633 - part 1 - Upstream FadedText to compose.base r=#android-reviewers

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1948633 - part 2 - Ensure proper alignment and no fading if text fits r=#android-reviewers

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1948633 - part 3 - Render pageOrigin from the state r=#android-reviewers

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1948633 - part 4 - Use pageOrigin in samples and Fenix r=#android-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f61bd95b4fc1
part 1 - Upstream FadedText to compose.base r=android-reviewers,007
https://hg.mozilla.org/integration/autoland/rev/ddbf11016857
part 2 - Ensure proper alignment and no fading if text fits r=android-reviewers,tchoh
https://hg.mozilla.org/integration/autoland/rev/4844ed893da8
part 3 - Render pageOrigin from the state r=android-reviewers,android-l10n-reviewers,delphine,tchoh
https://hg.mozilla.org/integration/autoland/rev/370bd27c409e
part 4 - Use pageOrigin in samples and Fenix r=android-reviewers,tchoh

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/f61bd95b4fc1
https://hg.mozilla.org/mozilla-central/rev/ddbf11016857
https://hg.mozilla.org/mozilla-central/rev/4844ed893da8
https://hg.mozilla.org/mozilla-central/rev/370bd27c409e

Comment 7

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1948633 - Use enums for page origin's fadeDirection and textGravity properties r=#android-reviewers

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 9

[Phabricator Automation]

Comment on attachment 9480814 [details]
Bug 1948633 - Use enums for page origin's fadeDirection and textGravity properties r=#android-reviewers

Revision D246562 was moved to bug 1962332. Setting attachment 9480814 [details] to obsolete.