1948671 - [composable toolbar] Build a Text composable with support for faded overflow text at the start and at the end

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, task, P2)

Description

[Petru-Mugurel Lingurar [:petru]]

Attachment: image.png

Currently the display URL's overflow (the end of it) is faded away.
For Phase 2 of the toolbar redesign we need to be able to show the last part of the URL while fading out the beginning (design attached).
This configuration needs to be supported in the pageOrigin configuration of DisplayState and then rendered as expected.

Comment 1

[[:harrisono]]

Attachment: Bug 1948671 - Create FadedText composable

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Attachment: Android Views APIs related to fading

Seeing the proposed patch I think the fade functionality could be split between

• the new text composable which can be configured to
  • clip the start part or the end part of the text if it doesn't fit the available space
  • fade the start or the end of the text if it doesn't fit the available space
• a fading edge Modifier used by this ^^ which could also easily add a gradient (with configurable colors, size and gravity) to any composable.
  This could be nice to have for other features later and would bring us closer to the fading edge support normal Views have.
  Added a screenshot of the APIs normal views have that we should probably also support. For now I think it's okay for this Modifier to support only start & end gradients.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d99ae483c0f
Create FadedText composable r=android-reviewers,tchoh

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/5d99ae483c0f